tabBarOnPress implemented on TabNavigator to reset Home stack #497
Conversation
Codecov Report
@@ Coverage Diff @@
## master #497 +/- ##
==========================================
+ Coverage 28.18% 28.19% +0.01%
==========================================
Files 172 172
Lines 2803 2802 -1
Branches 412 412
==========================================
Hits 790 790
+ Misses 1702 1701 -1
Partials 311 311
Continue to review full report at Codecov.
|
|
even with the client upgrades etc this is still necessary? |
| NavigationActions.navigate({ routeName: 'Root' }), | ||
| ], | ||
| }); | ||
| navigation.dispatch(resetAction); |
There was a problem hiding this comment.
did you try ditching the reset and just using navigation.navigate('Root');?
There was a problem hiding this comment.
it might help if you explain what you tried before you came to this being the best option
There was a problem hiding this comment.
This was the first thing I tried, and its what 'the internet' documents as the correct way to reset a stack.
There is currently nothing in our code to reset the stack and nothing documented in stacknav that would suggest it should be resetting. When we swap tabs it should just keep the set of tabs in that stack in place.
There was a problem hiding this comment.
If you just try nav to root you will end up with a weirdly large stack of screens in your stack i believe as it would just add another home screen to the mix.
|
I'd like to stall this a little longer while I try to figure out a better solution. |
|
Bump. come up with a better solution or accept my standard, by the book, recommended way of doing it. |
|
Bump |
sdunster
force-pushed
the
tdykes.home_TabNavigator_reset_stack
branch
from
89b3782 to
71c1916
Compare
|
rebased |
| tabBarIcon: ({ tintColor }) => <Icon size={34} name="home" color={tintColor} />, | ||
| }, | ||
| tabBarOnPress() { | ||
| const resetAction = NavigationActions.reset({ |
There was a problem hiding this comment.
could you not do this only if the tab is already selected?
There was a problem hiding this comment.
I played around with detecting that and its possible.
But found that users would be on another tab and want to go home so press home, and it wouldnt take them home, and that was confusing.
|
Ok I tested it and here is what I observed. I don't think your description made it clear. On iOS normally (before this diff)
After the diff:
I added one more comment inline with a suggested change that I think would satisfy all of my concerns and ensure consistency across platforms although I'd still prefer to avoid the need for it on iOS by fixing the underlying hierarchy problem. tl;dr I think we should continue to stall this PR and look for a better fix. If you think it is absolutely necessary because navigation is completely undesirable on Android and you wish to make it worse for iOS then I won't stop you from merging it. |
Pressing the Home button will empty the home stack (basically takes you back home).
Theres a minor animation glitch due to the nav action but ill see what IOS does with it before I work to hard to fix it.