Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add create_plugin_regitries to base_install #818

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

biosafetylvl5
Copy link
Collaborator

Reviewer Checklist

PR author: Please ensure you meet all of the below requirements, and check boxes appropriately.

Reviewers: Please confirm all required testing/documentation has been completed prior to approving.

Remove lines that are not applicable, explain if you select "NO REQUIRED"

  • Required existing tests pass (ie full_test.sh, others as appropriate)
  • NO REQUIRED existing tests (explain why not required)
  • Required unit tests added and pass for new/modified functionality
  • NO REQUIRED unit tests (explain why not required)
  • Required integration tests added and pass for new/modified functionality
  • NO REQUIRED integration tests (explain why not required)
  • Required documentation added for new/modified functionality
  • NO REQUIRED documentation (explain why not required)
  • Required release notes added for new/modified functionality
  • NO REQUIRED release notes (explain why not required)
  • Required updates to other repos complete
  • NO REQUIRED updates to other repos (explain why not required)

https://github.com/NRLMMD-GEOIPS/.github/blob/main/.github/review-template.md

Related Issues

fixes NRLMMD-GEOIPS/geoips#NNN

Testing Instructions

Summary

Output

@biosafetylvl5 biosafetylvl5 marked this pull request as draft November 6, 2024 17:57
Copy link
Contributor

@evrose54 evrose54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me once release notes are added!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants