Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

687-WORKSHOP-viirs-hdf5 #731

Merged
merged 3 commits into from
Aug 7, 2024
Merged

687-WORKSHOP-viirs-hdf5 #731

merged 3 commits into from
Aug 7, 2024

Conversation

AJThorpe
Copy link
Contributor

@AJThorpe AJThorpe commented Aug 7, 2024

Reviewer Checklist

PR author: Please ensure you meet all of the below requirements, and check boxes appropriately.

Reviewers: Please confirm all required testing/documentation has been completed prior to approving.

Remove lines that are not applicable, explain if you select "NO REQUIRED"

  • Required existing tests pass (ie full_test.sh, others as appropriate)
  • NO REQUIRED existing tests (explain why not required)
  • Required unit tests added and pass for new/modified functionality
  • NO REQUIRED unit tests (explain why not required)
  • Required integration tests added and pass for new/modified functionality
  • NO REQUIRED integration tests (explain why not required)
  • Required documentation added for new/modified functionality
  • NO REQUIRED documentation (explain why not required)
  • Required release notes added for new/modified functionality
  • NO REQUIRED release notes (explain why not required)
  • Required updates to other repos complete
  • NO REQUIRED updates to other repos (explain why not required)

https://github.com/NRLMMD-GEOIPS/.github/blob/main/.github/review-template.md

Related Issues

  • Creates VIIRS SDR HDF5 reader for geoips workshop

Testing Instructions

Summary

Output

@AJThorpe AJThorpe self-assigned this Aug 7, 2024
@AJThorpe
Copy link
Contributor Author

AJThorpe commented Aug 7, 2024

@mindyls @jsolbrig @cpcamacho

Why are there corrections done to the Visible products for VIIRS netcdf files? When looking at two files from the same location, and looking at the visible bands I get separate values for the SDR and the netcdf files: (hdf_xrt is SDR files with viirs_sdr_hdf5 and nc_xr is Netcdf files opened with viirs_netcdf)

In [21]: hdf_xrt['MOD-Vis'].M05Ref.max(), hdf_xrt['MOD-Vis'].M05Ref.min(), hdf_xrt['MOD-Vis'].M05Ref.mean()
Out[21]: 
(<xarray.DataArray 'M05Ref' ()>
 array(121.8136, dtype=float32),
 <xarray.DataArray 'M05Ref' ()>
 array(2.361164, dtype=float32),
 <xarray.DataArray 'M05Ref' ()>
 array(28.562603, dtype=float32))

In [22]: nc_xr['MOD-Vis'].M05Ref.max(), nc_xr['MOD-Vis'].M05Ref.min(), nc_xr['MOD-Vis'].M05Ref.mean()
Out[22]: 
(<xarray.DataArray 'M05Ref' ()>
 array(1.2865295, dtype=float32),
 <xarray.DataArray 'M05Ref' ()>
 array(0.02233079, dtype=float32),
 <xarray.DataArray 'M05Ref' ()>
 array(0.25161928, dtype=float32))

For the visible product there are several data manipulations done; a scale factor of 100, gamma correction of 1.5, and a Sun Zenith correction. Do we have to apply these to the Visible bands of the SDR files? Or is there a paper discussing when this is needed?

I think we have two clear options to take:

  • Figure out what differences are between the radiances & reflectance for the visible and infrared bands between netcdf and SDR files (are netcdf L2 or L1b?) and correct accordingly.

OR

  • Create separate products for VIIRS SDR files (not preferred for transition reasons, web products would be confusing, etc....)

@AJThorpe
Copy link
Contributor Author

AJThorpe commented Aug 7, 2024

Per Mindy:

  • Leave it at 0-100 range (we'll do 0-100 for reflectance and 0-1 for albedo, and this is ref)
  • Apply solar zenith angle correction in the hdf5 reader to the visible reflectance
  • Remove the gamma correction

@AJThorpe
Copy link
Contributor Author

AJThorpe commented Aug 7, 2024

VIIRS radiance/reflectance correction will be done later! See issue #733

@AJThorpe AJThorpe merged commit 29cb000 into main Aug 7, 2024
12 checks passed
@AJThorpe AJThorpe deleted the 687-WORKSHOP-viirs-hdf5 branch August 7, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants