Fix bad listeners detachment for characteristics #563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please bump to 1.7.1 |
GogoVega
requested review from
caitken-com,
crxporter and
TheNON75
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes node-red/node-red#4842.
Listeners are not properly detached which adds a series of listeners to each deployment (other than full deployment).
To test this issue:
There should be two messages from the HK debug.
[{"id":"3c5fb17451b849c7","type":"inject","z":"d30d213aa12fd3db","name":"On","props":[{"p":"payload"}],"repeat":"","crontab":"","once":false,"onceDelay":0.1,"topic":"","payload":"{\"On\":true}","payloadType":"json","x":110,"y":140,"wires":[["91ddaffd181570b4","f7bbf85c83df88a2"]]},{"id":"1e84d6d7ed508964","type":"inject","z":"d30d213aa12fd3db","name":"Off","props":[{"p":"payload"}],"repeat":"","crontab":"","once":false,"onceDelay":0.1,"topic":"","payload":"{\"On\":false}","payloadType":"json","x":110,"y":200,"wires":[["91ddaffd181570b4","f7bbf85c83df88a2"]]},{"id":"91ddaffd181570b4","type":"debug","z":"d30d213aa12fd3db","name":"debug 2","active":true,"tosidebar":true,"console":false,"tostatus":false,"complete":"false","statusVal":"","statusType":"auto","x":300,"y":200,"wires":[]},{"id":"f7bbf85c83df88a2","type":"homekit-service","z":"d30d213aa12fd3db","isParent":true,"hostType":"0","bridge":"4b8b281abe324526","accessoryId":"","parentService":"","name":"Test Light","serviceName":"Lightbulb","topic":"","filter":false,"manufacturer":"NRCHKB","model":"0.170.11","serialNo":"Default Serial Number","firmwareRev":"0.170.11","hardwareRev":"0.170.11","softwareRev":"0.170.11","cameraConfigVideoProcessor":"ffmpeg","cameraConfigSource":"","cameraConfigStillImageSource":"","cameraConfigMaxStreams":2,"cameraConfigMaxWidth":1280,"cameraConfigMaxHeight":720,"cameraConfigMaxFPS":10,"cameraConfigMaxBitrate":300,"cameraConfigVideoCodec":"libx264","cameraConfigAudioCodec":"libfdk_aac","cameraConfigAudio":false,"cameraConfigPacketSize":1316,"cameraConfigVerticalFlip":false,"cameraConfigHorizontalFlip":false,"cameraConfigMapVideo":"0:0","cameraConfigMapAudio":"0:1","cameraConfigVideoFilter":"scale=1280:720","cameraConfigAdditionalCommandLine":"-tune zerolatency","cameraConfigDebug":false,"cameraConfigSnapshotOutput":"disabled","cameraConfigInterfaceName":"","characteristicProperties":"{}","waitForSetupMsg":false,"outputs":2,"adaptiveLightingOptionsEnable":false,"adaptiveLightingOptionsCustomTemperatureAdjustment":"","x":300,"y":140,"wires":[["13965e9bcf4bc834"],[]]},{"id":"13965e9bcf4bc834","type":"debug","z":"d30d213aa12fd3db","name":"debug 3","active":true,"tosidebar":true,"console":false,"tostatus":false,"complete":"true","targetType":"full","statusVal":"","statusType":"auto","x":480,"y":160,"wires":[]},{"id":"4b8b281abe324526","type":"homekit-bridge","bridgeName":"TEST","pinCode":"3690-9025","port":"","advertiser":"bonjour-hap","allowInsecureRequest":false,"manufacturer":"NRCHKB","model":"0.170.11","serialNo":"Default Serial Number","firmwareRev":"0.170.11","hardwareRev":"0.170.11","softwareRev":"0.170.11","bind":"","bindType":"str","customMdnsConfig":false,"mdnsMulticast":true,"mdnsInterface":"","mdnsPort":"","mdnsIp":"","mdnsTtl":"","mdnsLoopback":true,"mdnsReuseAddr":true,"allowMessagePassthrough":true}]