Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Adaptive Lighting support #335

Open
sjorge opened this issue Nov 13, 2020 · 9 comments
Open

[Feature Request]: Adaptive Lighting support #335

sjorge opened this issue Nov 13, 2020 · 9 comments
Assignees
Labels
enhancement 👍 New feature or request v1.5

Comments

@sjorge
Copy link

sjorge commented Nov 13, 2020

Is your feature request related to a problem? Please describe.
Nope, would just like to use homekits adaptive lighting, I got it working with a complex schedule in node red at the moment but while this is enabled I cannot set a custom override via homekit. Having both would be better.

Describe the solution you'd like
Adaptive Lighting support, I think we need to bumb hap-nodejs for starters, en maybe expose some extra services.

Describe alternatives you've considered
See above, I have a complex manual schedule and just have the bulbs as brightness expose to homekit. Not idea as I cannot manual override the color like this.

Additional context
n/a

@sjorge sjorge added the enhancement 👍 New feature or request label Nov 13, 2020
@crxporter
Copy link
Member

Is it included in HAP-NodeJS yet?

@jorschra
Copy link

jorschra commented Nov 13, 2020

Looks like it, there is a or open to rename all the reference as they had it as ambient lighting first... so the original seems to be merged a while ago

homebridge/HAP-NodeJS#855

@crxporter
Copy link
Member

Using both accounts today, @sjorge ? I thought we had a new user then I saw it's still you.

@sjorge
Copy link
Author

sjorge commented Nov 13, 2020

Wrong tab container yeah, that was the work one.

@Shaquu
Copy link
Member

Shaquu commented Nov 13, 2020

Okay, looks like HAP-NodeJS has something called Controllers. Adaptive Lightning Controller is still in beta.
I will need to look how many of them we have and how to add them in the best way using NRCHKB.

https://github.com/homebridge/HAP-NodeJS/blob/585ede3f85b1989e1097b76f45c72925fa2f236b/src/accessories/Light-AdaptiveLighting_accessory.ts#L116

Probably every controller must be handled separately.

@dmitrystarikov
Copy link

I found this: https://developers.homebridge.io/HAP-NodeJS/classes/adaptivelightingcontroller.html
I hope this is helpful :)

@DedMsk
Copy link

DedMsk commented Feb 16, 2021

homebridge/homebridge#2765

@TheNON75 TheNON75 added the v1.5 label Oct 4, 2021
Shaquu added a commit that referenced this issue Jun 17, 2024
@Shaquu
Copy link
Member

Shaquu commented Jun 17, 2024

Okay guys, check latest dev version 1.7.0-dev.1

@sjorge
Copy link
Author

sjorge commented Jun 20, 2024

There seems to be some sort of race:

21 Jun 00:08:08 - [error] [homekit-service2: 2Test] Failed to configure adaptive lightning due to AssertionError [ERR_ASSERTION]: Lightbulb must have the ColorTemperature characteristic added!
2024-06-20T22:08:08.023Z NRCHKB-Error:ServiceUtils2 [ 2Test:b9a76c3ee5bdc616] Failed to configure adaptive lightning due to AssertionError [ERR_ASSERTION]: Lightbulb must have the ColorTemperature characteristic added!
[
    {
        "id": "b9a76c3ee5bdc616",
        "type": "homekit-service2",
        "z": "bef3f7d0d4dc601f",
        "isParent": true,
        "hostType": "0",
        "bridge": "b8a669c67b5dfb61",
        "accessoryId": "",
        "parentService": "",
        "name": " 2Test",
        "serviceName": "Lightbulb",
        "topic": "",
        "filter": false,
        "manufacturer": "NRCHKB",
        "model": "0.170.1",
        "serialNo": "Default Serial Number",
        "firmwareRev": "0.170.1",
        "hardwareRev": "0.170.1",
        "softwareRev": "0.170.1",
        "cameraConfigVideoProcessor": "ffmpeg",
        "cameraConfigSource": "",
        "cameraConfigStillImageSource": "",
        "cameraConfigMaxStreams": 2,
        "cameraConfigMaxWidth": 1280,
        "cameraConfigMaxHeight": 720,
        "cameraConfigMaxFPS": 10,
        "cameraConfigMaxBitrate": 300,
        "cameraConfigVideoCodec": "libx264",
        "cameraConfigAudioCodec": "libfdk_aac",
        "cameraConfigAudio": false,
        "cameraConfigPacketSize": 1316,
        "cameraConfigVerticalFlip": false,
        "cameraConfigHorizontalFlip": false,
        "cameraConfigMapVideo": "0:0",
        "cameraConfigMapAudio": "0:1",
        "cameraConfigVideoFilter": "scale=1280:720",
        "cameraConfigAdditionalCommandLine": "-tune zerolatency",
        "cameraConfigDebug": false,
        "cameraConfigSnapshotOutput": "disabled",
        "cameraConfigInterfaceName": "",
        "characteristicProperties": "{\"On\":true,\"Brightness\":true,\"Hue\":true,\"Saturation\":true,\"ColorTemperature\":true}",
        "waitForSetupMsg": false,
        "useEventCallback": false,
        "outputs": 1,
        "adaptiveLightingOptionsEnable": true,
        "adaptiveLightingOptionsMode": "1",
        "adaptiveLightingOptionsCustomTemperatureAdjustment": "",
        "x": 430,
        "y": 660,
        "wires": [
            []
        ]
    },
    {
        "id": "b8a669c67b5dfb61",
        "type": "homekit-bridge",
        "bridgeName": "Bridge",
        "pinCode": "123-45-678",
        "port": "60942",
        "advertiser": "ciao",
        "allowInsecureRequest": false,
        "manufacturer": "Test",
        "model": "NRBridge",
        "serialNo": "1234",
        "firmwareRev": "1.0.0",
        "hardwareRev": "1.0.0",
        "softwareRev": "1.0.2",
        "customMdnsConfig": false,
        "mdnsMulticast": true,
        "mdnsInterface": "",
        "mdnsPort": "",
        "mdnsIp": "",
        "mdnsTtl": "",
        "mdnsLoopback": true,
        "mdnsReuseAddr": true,
        "allowMessagePassthrough": false
    }
]

Shaquu added a commit that referenced this issue Sep 19, 2024
### Fixed

- Removed vulnerable module 'ip' [#545](#545)
- msg.context now handled properly

### Added

- Adaptive Lighting support [#335](#335)
- By default, registered Eve.app Characteristics for power management - for existing setup, requires old custom characteristics file to be removed

### Changed

- Updated hap-nodejs [0.11.1 to 0.12.3-beta.18](https://github.com/homebridge/HAP-NodeJS/blob/latest/CHANGELOG.md) (features
  and bug fixes)
- Dependencies upgrade
- Node `10`, `12` and `16` no longer supported, use Node 20! Or at least 18
- Updated GitHub Actions
- Some trivial PinCodes are no longer allowed
- MDNS Configuration is now deprecated, use Bind instead
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 👍 New feature or request v1.5
Projects
None yet
Development

No branches or pull requests

7 participants