Skip to content

Conversation

thomas694
Copy link
Contributor

Adds capability to handle JSON files with value 'undefined'.
Also added new option in settings and storing its value in settings file.

Copy link
Collaborator

@SinghRajenM SinghRajenM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good feature indeed, but incomplete.
Would you mind extending it for compress json, validate josn and treeview dialog too?

Add: extend functionality to 'compress', 'validate' and 'treeview dialog'
Fix: regex ignores 'undefined' in arrays
@thomas694
Copy link
Contributor Author

Would you mind extending it for compress json, validate josn and treeview dialog too?

No, sure, it makes sense.
But I asked myself the question, if I as a user wouldn't rather expect that the validate function validates the untouched text (against the standard) instead of applying changes/workarounds first. But then it would also make sense to have also a separate menu entry for validating only, because opening the panel could already change the text.

@thomas694
Copy link
Contributor Author

!?

Copy link
Collaborator

@SinghRajenM SinghRajenM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve conflicts too.

@thomas694
Copy link
Contributor Author

thomas694 commented Apr 14, 2023

Thanks for taking the time to do the review. I did the requested changes.

@SinghRajenM
Copy link
Collaborator

SinghRajenM commented Apr 23, 2023

Thanks for taking the time to do the review. I did the requested changes.

It does not highlight error position properly for below input:
"Another test":[undefined, null, undefined, null, infinity, "undefined", Undefined]

In this error position highlighting should start with infinity. Mind the case for infinity.

Fix: checkbox overlapped
Fix: error in original ReportError code
@thomas694
Copy link
Contributor Author

It does not highlight

I fixed it.
There was also an error with the original "ReportError" code, it selected beyond the end of the current selection.

@SinghRajenM SinghRajenM merged commit 8920520 into NPP-JSONViewer:master Apr 30, 2023
@thomas694 thomas694 deleted the add-handle-json-files-with-value-undefined branch April 30, 2023 21:01
molsonkiko added a commit to molsonkiko/JsonToolsNppPlugin that referenced this pull request May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants