-
Notifications
You must be signed in to change notification settings - Fork 157
Handle JSON files with value 'undefined' #146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle JSON files with value 'undefined' #146
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good feature indeed, but incomplete.
Would you mind extending it for compress json, validate josn and treeview dialog too?
Add: extend functionality to 'compress', 'validate' and 'treeview dialog' Fix: regex ignores 'undefined' in arrays
…e-json-files-with-value-undefined
No, sure, it makes sense. |
!? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please resolve conflicts too.
…e-json-files-with-value-undefined
Thanks for taking the time to do the review. I did the requested changes. |
It does not highlight error position properly for below input: In this error position highlighting should start with |
Fix: checkbox overlapped Fix: error in original ReportError code
I fixed it. |
per NPP-JSONViewer/JSON-Viewer#146 some people care about this
Adds capability to handle JSON files with value 'undefined'.
Also added new option in settings and storing its value in settings file.