-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Psd/develop #23
Psd/develop #23
Conversation
…tc_20191210 ufs_public_release: update from DTC (fix compiler warnings)
Ufs public release
Ufs public release
…ber of OpenMP threads provided from the calling model
release/public-v1: partial fix to threading issue
update documentation
update develop with master
Release/public v1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. As per yesterday's discussion, will approve for merging when tested in full with a ufs-weather-model commit on all platforms (since this is going to the authoritative branch used by the UFS models).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am approving this before my two days of vacation, so that it can be merged once the regression tests passed.
This PR is for pulling in the threading fix and documentation from the release/public-v1 branch.
All regression tests pass on hera.