Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Psd/develop #23

Merged
merged 62 commits into from
May 27, 2020
Merged

Psd/develop #23

merged 62 commits into from
May 27, 2020

Conversation

pjpegion
Copy link
Collaborator

This PR is for pulling in the threading fix and documentation from the release/public-v1 branch.
All regression tests pass on hera.

Copy link
Collaborator

@climbfuji climbfuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. As per yesterday's discussion, will approve for merging when tested in full with a ufs-weather-model commit on all platforms (since this is going to the authoritative branch used by the UFS models).

Copy link
Collaborator

@lisa-bengtsson lisa-bengtsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

Copy link
Collaborator

@climbfuji climbfuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am approving this before my two days of vacation, so that it can be merged once the regression tests passed.

@pjpegion pjpegion merged commit 12a4dc6 into master May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants