Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify config module #790

Merged
merged 16 commits into from
Jul 1, 2024
Merged

Simplify config module #790

merged 16 commits into from
Jul 1, 2024

Conversation

shorvath-noaa
Copy link
Contributor

Added better default values for several parameters. Removed extra='forbid' limitation everywhere.

Additions

Removals

Changes

Testing

Screenshots

Notes

Todos

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Visually tested in supported browsers and devices (see checklist below 👇)
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

Testing checklist

Target Environment support

  • Windows
  • Linux
  • Browser

Accessibility

  • Keyboard friendly
  • Screen reader friendly

Other

  • Is useable without CSS
  • Is useable without JS
  • Flexible from small to large screens
  • No linting errors or warnings
  • JavaScript tests are passing

shorvath-noaa and others added 3 commits June 27, 2024 19:39
@shorvath-noaa
remove unnecessary parameters
7843120
@shorvath-noaa
remove unnecessary parameters from HYF noDA test run
7fa4680
@AminTorabi-NOAA
DataAssimilation logger (NOAA-OWP#786)
b8f58eb 
* DataAssimilation logger

* DataAssimilation logger update

* DataAssimilation logger update V2

* DataAssimilation logger update all

* DataAssimilation logger update extra text deleted

* DataAssimilation logger save directory

* Update on LOG detail

* config update

* remove extra information

* updating on showtiming
@AminTorabi-NOAA
Copy link
Contributor

Sean, there are some conflict with master branch, would you rebase your branch

@shorvath-noaa shorvath-noaa dismissed AminTorabi-NOAA’s stale review June 28, 2024 20:21

The merge-base changed after approval.

AminTorabi-NOAA
AminTorabi-NOAA previously approved these changes Jul 1, 2024
View reviewed changes
@shorvath-noaa shorvath-noaa dismissed AminTorabi-NOAA’s stale review July 1, 2024 15:05

The merge-base changed after approval.

AminTorabi-NOAA
AminTorabi-NOAA previously approved these changes Jul 1, 2024
View reviewed changes
@shorvath-noaa shorvath-noaa dismissed AminTorabi-NOAA’s stale review July 1, 2024 15:16

The merge-base changed after approval.

@shorvath-noaa shorvath-noaa merged commit a0422a0 into NOAA-OWP:master Jul 1, 2024
4 checks passed
@shorvath-noaa shorvath-noaa mentioned this pull request Jul 3, 2024
Closed
21 tasks
@aaraney aaraney mentioned this pull request Jul 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AminTorabi-NOAA AminTorabi-NOAA AminTorabi-NOAA left review comments

@kumdonoaa kumdonoaa Awaiting requested review from kumdonoaa

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shorvath-noaa @AminTorabi-NOAA