Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always drop waterbody col from network df #725

Merged
merged 1 commit into from
Jan 11, 2024
Merged

Always drop waterbody col from network df #725

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/troute-network/troute/HYFeaturesNetwork.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -460,7 +460,6 @@ def preprocess_waterbodies(self, lakes):
.to_dict()
)

self._dataframe = self.dataframe.drop('waterbody', axis=1)

# if waterbodies are being simulated, adjust the connections graph so that
# waterbodies are collapsed to single nodes. Also, build a mapping between
Expand All @@ -487,6 +486,8 @@ def preprocess_waterbodies(self, lakes):
self._waterbody_type_specified = False
self._link_lake_crosswalk = None

self._dataframe = self.dataframe.drop('waterbody', axis=1)

def preprocess_data_assimilation(self, network):
if not network.empty:
gages_df = network[['id','hl_uri','hydroseq']].drop_duplicates()
Expand Down