Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated run_with_BMI with BMI compliant arrays #711

Merged
merged 3 commits into from
Dec 7, 2023

Conversation

JurgenZach-NOAA
Copy link
Contributor

Implemented functionality of PR 702 (NMI compliant arrays) into two standard examples.

Additions

  • Updated run_with_BMI.py script with new BMI compliant arrays comprising (mainly) gage dataframes
  • Added two examples: Standard AnA, and Short Range Forecast

Removals

Changes

Testing

  1. python3 run_with_BMI.py (after compiling t-route, from LowerColorado_TX_v4 test folder)

Screenshots

Notes

Todos

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Visually tested in supported browsers and devices (see checklist below 👇)
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

Testing checklist

Target Environment support

  • Windows
  • Linux
  • Browser

Accessibility

  • Keyboard friendly
  • Screen reader friendly

Other

  • Is useable without CSS
  • Is useable without JS
  • Flexible from small to large screens
  • No linting errors or warnings
  • JavaScript tests are passing

@AminTorabi-NOAA
Copy link
Contributor

AminTorabi-NOAA commented Dec 7, 2023

Jurgen, couple points I saw at the first glance:

  • I think you add all the binary files to your PR by mistake. Would you take them out of the PR.
  • Also change in the compiler file, that's a separate PR take that one out to.

@JurgenZach-NOAA
Copy link
Contributor Author

OK fixed

@JurgenZach-NOAA JurgenZach-NOAA merged commit 31cfe11 into NOAA-OWP:master Dec 7, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants