-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix - lock cython version, add missing pip deps #667
Conversation
up from 0.29.36
As this is still open and related to this #614 I'm going to also set pyarrow <12.0 and retest |
|
pandas>=1.1.5 | ||
xarray | ||
netcdf4 | ||
pyyaml | ||
toolz | ||
joblib | ||
deprecated | ||
pyarrow<12.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please double check the installation and test run without any version specification on thepyarrow
? Because on my branch here build log, downloads pyarrow-14.0.0
and test ran just fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the pyarrow version is an issue specific to running t-route with ngen, #614
I'm not sure if it would be best to address the issue closest to the root (here) to stop other things that use it all needing the same patch. Or if it should be addressed in ngen as that's where it appears to break things?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JoshCu @TrupeshKumarPatel I tested these changes and they work fine on my end. Is the above conversation about locking in pyarrow version ongoing or is this PR ready for approval/merging?
Fixes #651
breakout from #660
Summary
Adds required pip packages to requirements.txt
Locks cython version to fix ./compile.sh
requirements.txt
Additions
Changes
Testing
Before
After
Screenshot is of a docker build step successfully running, before it would fail on that step.
Notes
Using legacy 'setup.py install' for troute.network, since package 'wheel' is not installed.
this warning does appear when compiling.Without version locks on all the pip packages, it would be a good idea to have some schedulled tests to catch any breaking updates to packages. #669 or #670 could help?
Todos
Checklist