default creation of empty waterbody dataframes

[shorvath-noaa]

Creates empty dataframes for waterbody_df and waterbody_types_df if no valid waterbody layer are found in the geopackage

Additions

• try/except logic while reading waterbody layers in geopackage
• if there are no waterbody parameters, create empty waterbody dataframes.

Removals

Changes

Testing

Screenshots

Notes

Todos

Checklist

• PR has an informative and human-readable title
• Changes are limited to a single goal (no scope creep)
• Code can be automatically merged (no conflicts)
• Code follows project standards (link if applicable)
• Passes all existing automated tests
• Any change in functionality is tested
• New functions are documented (with a description, list of inputs, and expected output)
• Placeholder code is flagged / future todos are captured in comments
• Visually tested in supported browsers and devices (see checklist below 👇)
• Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
• Reviewers requested with the Reviewers tool ➡️

Testing checklist

Target Environment support

• Windows
• Linux
• Browser

Accessibility

• Keyboard friendly
• Screen reader friendly

Other

• Is useable without CSS
• Is useable without JS
• Flexible from small to large screens
• No linting errors or warnings
• JavaScript tests are passing

[hellkite500]

I think this is reasonable for now, but might be a good idea to log some details later, especially if someone may be expecting to have reservoir data, but it doesn't read correct or is missing...this silent failure might be difficult to track down.

[shorvath-noaa]

I agree. I need to go back and update a lot of the logging/debugging as much of it got jumbled up when we transferred to HYFeatures. I'll add this to that list.