Reformat qlat inputs #595
Merged
Reformat qlat inputs #595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kumdonoaa
previously approved these changes
Dec 5, 2022
| raise(RuntimeError("Output binary qlat folder supplied in config does not exist")) | ||
| elif len(os.listdir(binary_folder)) != 0: | ||
| raise(RuntimeError("Output binary qlat folder supplied in config is not empty")) | ||
|
|
There was a problem hiding this comment.
All files in binary_folder should be cleanly deleted for a new simulation. When Delete option is used, one hidden file, i.e., .ipynb_checkpoints, still remains to give the error of line 53. It is recommended to use "rm -r * .*" to cleanly delete all files. Other than this, this PR successfully ran with nextgen-generated csv files.
There was a problem hiding this comment.
This new change at line 52 solved my initial issue. Well done!!
kumdonoaa
approved these changes
Dec 6, 2022
| raise(RuntimeError("Output binary qlat folder supplied in config does not exist")) | ||
| elif len(os.listdir(binary_folder)) != 0: | ||
| raise(RuntimeError("Output binary qlat folder supplied in config is not empty")) | ||
|
|
There was a problem hiding this comment.
This new change at line 52 solved my initial issue. Well done!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added capability to convert nexus qlat csv files output by ngen (single file per nexus with all timesteps) into hourly parquet files (one file for every hour containing all nexus points) that conforms to t-route's current method of reading qlat input data.
Additions
Removals
Changes
Testing
Screenshots
Notes
Todos
Checklist
Testing checklist
Target Environment support
Accessibility
Other