Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bmi_Adapter: drop unused 'allow_exceed_end_time' member #842

Merged

Conversation

PhilMiller
Copy link
Contributor

@PhilMiller PhilMiller commented Jun 26, 2024

The Formulations actually know and handle this behavior. Its presence in the Adapter layer is a relic.

Changes

  • Remove allow_exceed_end_time members and constructor parameters

Testing

  1. ctest, CI

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

@PhilMiller PhilMiller merged commit 303eb81 into NOAA-OWP:master Jun 27, 2024
19 checks passed
@PhilMiller PhilMiller deleted the PhilMiller/bmi-adapter-exceed-time branch June 27, 2024 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants