Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Routing test: Minor cleanups #823

Merged
merged 1 commit into from
May 20, 2024
Merged

Routing test: Minor cleanups #823

merged 1 commit into from
May 20, 2024

Conversation

PhilMiller
Copy link
Contributor

@PhilMiller PhilMiller commented May 20, 2024 •
edited
Loading

Fix one-off typos and infelicities in Routing test

Removals

  • Delete commented out using namespace std;

Changes

  • Fix typos

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

@hellkite500 hellkite500 merged commit 70545d1 into NOAA-OWP:master May 20, 2024
19 checks passed
@PhilMiller PhilMiller deleted the PhilMiller/fix-typos-2024-05-20 branch May 21, 2024 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hellkite500 hellkite500 hellkite500 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PhilMiller @hellkite500