Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop 'using std::shared_ptr' from high-level header #822

Merged
merged 1 commit into from
May 17, 2024

Conversation

PhilMiller
Copy link
Contributor

@PhilMiller PhilMiller commented May 16, 2024

It's really poor form to lift standard library names into the global namespace. Drop the using std::shared_ptr statement, and qualify the handful of places across the code that depended on it.

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

@PhilMiller PhilMiller requested a review from program-- May 16, 2024 23:36
@program-- program-- merged commit 6114cd5 into NOAA-OWP:master May 17, 2024
19 checks passed
@PhilMiller PhilMiller deleted the PhilMiller/fix-using branch May 20, 2024 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants