Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete never-implemented stub definition of AsyncDataProvider #808

Merged

Conversation

PhilMiller
Copy link
Contributor

@PhilMiller PhilMiller commented Apr 30, 2024

The class AsyncDataProvider is abstract, has no implementation, no tests, and no putative uses. Per git log -SAsyncDataProvider, is has never been referenced other than in the commit that introduced it.

Removals

  • Delete include/forcing/AsyncDataProvider.hpp

Testing

  1. CI

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

@PhilMiller PhilMiller marked this pull request as ready for review April 30, 2024 23:52
@PhilMiller PhilMiller merged commit dd66466 into NOAA-OWP:master May 1, 2024
19 checks passed
@PhilMiller PhilMiller deleted the PhilMiller/delete-async-provider branch May 1, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants