Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Formulation cleanup #796

Merged
merged 3 commits into from
Apr 19, 2024
Merged

Formulation cleanup #796

merged 3 commits into from
Apr 19, 2024

Conversation

PhilMiller
Copy link
Contributor

@PhilMiller PhilMiller commented Apr 19, 2024 •
edited
Loading

Various minor refactorings of Formulation and BMI_Multi_Formulation classes to get rid of some C++ excesses.

Testing

  1. Local unit tests pass
  2. CI

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

@PhilMiller PhilMiller marked this pull request as ready for review April 19, 2024 00:14
@PhilMiller PhilMiller merged commit 22ad948 into NOAA-OWP:master Apr 19, 2024
19 checks passed
@PhilMiller PhilMiller deleted the PhilMiller/formulation-cleanup branch April 19, 2024 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@program-- program-- program-- approved these changes

@hellkite500 hellkite500 Awaiting requested review from hellkite500

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PhilMiller @program--