Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loosen dependency on netcdf-cxx4 to 4.3.0 from 4.3.1 #740

Merged
merged 1 commit into from
Feb 15, 2024

Conversation

PhilMiller
Copy link
Contributor

@PhilMiller PhilMiller commented Feb 15, 2024

There was an API change that's not backwards compatible from 4.3.0 to 4.3.1, in adding a member function. Avoid using that member function to gain compatibility with the older release.

Changes

  • Use C API free function nc_free_string from base netcdf instead of member function freeString from separate C++ bindings in netcdf-cxx4

Testing

Modified version used in benchmark/scaling runs on Hera.

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

There was an API change that's not backwards compatible from 4.3.0 to
4.3.1, in adding a member function. Avoid using that member function
to gain compatibility with the older release.
@PhilMiller
Copy link
Contributor Author

PhilMiller commented Feb 15, 2024

This should probably be done independent of whether we vendor in netcdf-cxx4 (cf #729), since we'll presumably still use an external copy if it's part of the base netcdf installation

@PhilMiller PhilMiller marked this pull request as ready for review February 15, 2024 01:01
@program-- program-- merged commit ecac421 into master Feb 15, 2024
19 checks passed
@program-- program-- deleted the phil/netcdf-cxx4-4.3.0 branch February 15, 2024 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants