Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix t-route module build to install numpy #516

Merged
merged 3 commits into from
Apr 26, 2023
Merged

Conversation

hellkite500
Copy link
Member

t-route integration test fails to build t-route missing numpy dependency. This should ensure it is installed in the venv before attempting to build.

@hellkite500
Copy link
Member Author

Really confused as to why this fails to find numpy, I was pretty sure it should have been there, but figured it was worth a try to add it explicity, but it doesn't seem to help...

Requirement already satisfied: numpy in /home/runner/work/ngen/ngen/.venv/lib/python3.10/site-packages (from -r requirements.txt (line 1)) (1.24.3)
      ModuleNotFoundError: No module named 'numpy'

@mattw-nws
Copy link
Contributor

Yeah it looks like restricting the pip version <23.1 fixes this… the following build message is relevant, but I’m unclear exactly what to do about it:

DEPRECATION: troute.network is being installed using the legacy 'setup.py install' method, because the '--no-binary' option was enabled for it and this currently disables local wheel building for projects that don't have a 'pyproject.toml' file. pip 23.1 will enforce this behaviour change. A possible replacement is to enable the '--use-pep517' option. Discussion can be found at https://github.com/pypa/pip/issues/11451

@hellkite500
Copy link
Member Author

@mattw-nws I can't approve/review since I authored the original PR, but I think this is good enough for now, and I'll open an issue to track the above deprecation warning and remind us to clean this up. Can you approve and we can merge this?

@mattw-nws
Copy link
Contributor

@aaraney do you recognize the problem here and what we're supposed to do about it? This same issue--I think--affects this workaround for ngen+hdf5+pytables in DMOD's Dockerfile: https://github.com/NOAA-OWP/DMOD/blob/master/docker/main/ngen/Dockerfile#L350 ... and it may already be broken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants