Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing a minor bug - issue #449. #487

Merged
merged 1 commit into from
Jan 4, 2023
Merged

Conversation

stcui007
Copy link
Contributor

Fixing a minor error detected in build.

Additions

Removals

Changes

test/realizations/catchments/Bmi_Multi_Formulation_Test.cpp

Testing

Unit tests
Run ngen tests

Screenshots

Notes

The default build has the following selections: Bmi_C_Active=off, Bmi_Fortran_Active=off, Bmi_Python_Active=on.

Todos

Checklist

  • [x ] PR has an informative and human-readable title
  • [x ] Changes are limited to a single goal (no scope creep)
  • [x ] Code can be automatically merged (no conflicts)
  • [x ] Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

Testing checklist (automated report can be put here)

Target Environment support

  • [x ] Linux

@mattw-nws mattw-nws merged commit 46a8651 into NOAA-OWP:master Jan 4, 2023
@mattw-nws mattw-nws linked an issue Jan 4, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cmake build error for latest ngen master branch
2 participants