Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Noah to 9ede266 #465

Merged
merged 2 commits into from
Nov 9, 2022
Merged

Conversation

mattw-nws
Copy link
Contributor

@mattw-nws mattw-nws commented Nov 7, 2022

Update noah-owp-modular submodule to latest main branch as of this time

Additions

Removals

Changes

  • Moved submodule pin to 9ede266
  • Modified namelist .input files to match expectations of latest version

Testing

  1. Ran example_bmi_multi_realization_config_w_noah_pet_cfe.json successfully locally... note that this test "passes" in the workflows if the namelist files are not correct, somehow.

Screenshots

Notes

Todos

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

Testing checklist (automated report can be put here)

Target Environment support

  • Linux

@mattw-nws mattw-nws marked this pull request as ready for review November 9, 2022 17:23
@hellkite500 hellkite500 merged commit 07454f7 into NOAA-OWP:master Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants