Fix a smattering of errors and warnings with newer compilers #461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattw-nws
commented
Oct 28, 2022
| @@ -134,7 +134,9 @@ class CSVDataSelector : public CatchmentAggrDataSelector | |||
| CatchmentAggrDataSelector(std::string(), var, start, dur, units) | |||
| {} | |||
|
|
|||
| #if GCC_VERSION < 8 && !defined(__llvm__) | |||
There was a problem hiding this comment.
Finally tried this with GCC6... I did not see the warnings and it compiled... so it looks like 8 is the right version to break this on (maybe 7 but 🤷 ).
robertbartel
approved these changes
Oct 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes one actual build error in
NexusTests.cppand a bunch of warnings to clean up output.After this only the
GetValue->GetValuesdeprecation warning remains 🎉Additions
std::to string vector inNexusTests.cpp#ifaround Selector constructors that are only needed for older compilersoverridestatements that were being warned onRemovals
Changes
Testing
Screenshots
Notes
Todos
Checklist
Testing checklist (automated report can be put here)
Target Environment support