Refactor forcing and data provider #446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattw-nws
approved these changes
Oct 5, 2022
| @@ -32,7 +32,7 @@ namespace data_access { | |||
| * returning results from a nested call to the wrapped provider, this type's implementation ensures only the outputs | |||
| * set as provideable in this instance (i.e., the outer wrapper) are returned. | |||
| */ | |||
| class DeferredWrappedProvider : public WrappedForcingProvider | |||
| class DeferredWrappedProvider : public WrappedDataProvider | |||
There was a problem hiding this comment.
In future we might should rename this class also... but fine for now.
| @@ -15,7 +15,7 @@ using namespace std; | |||
| namespace data_access { | |||
| namespace test { | |||
| /** | |||
| * A trivial implementation, strictly for testing OptionalWrappedProvider. | |||
| * A trivial implementation, strictly for testing OptionalWrappedDataProvider. | |||
| */ | |||
| class TrivialForcingProvider : public GenericDataProvider { | |||
There was a problem hiding this comment.
I suppose I should have included this class in the list of renames... or maybe I meant this one and wrote OptionalWrappedForcingProvider instead (likely)... but since this is test-specific and does represent forcing data in the test this is fine for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additions
include/forcing/OptionalWrappedDataProvider.hpp
include/forcing/WrappedDataProvider.hpp
test/forcing/OptionalWrappedDataProvider_Test.cpp
Removals
include/forcing/OptionalWrappedProvider.hpp
include/forcing/WrappedForcingProvider.hpp
test/forcing/OptionalWrappedProvider_Test.cpp
Changes
include/forcing/DeferredWrappedProvider.hpp
include/realizations/catchment/Bmi_Module_Formulation.hpp
include/realizations/catchment/Bmi_Multi_Formulation.hpp
src/realizations/catchment/Bmi_Multi_Formulation.cpp
test/CMakeLists.txt
test/realizations/catchments/Bmi_Cpp_Multi_Array_Test.cpp
test/realizations/catchments/Bmi_Multi_Formulation_Test.cpp
Testing
Screenshots
Notes
Todos
Checklist
Testing checklist (automated report can be put here)
Target Environment support