Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Netcdf lumped usable #417

Merged
merged 19 commits into from
Jul 19, 2022
Merged

Conversation

mattw-nws
Copy link
Contributor

@mattw-nws mattw-nws commented May 20, 2022

Makes the lumped NetCDF DataProvider actually usable... if slow.

Additions

  • Added small .nc test file for unit tests

Removals

Changes

  • Fixes numerous things with the CMakeLists and modules for building NetCDF builds
  • The forcing directory and its contents are now a library in CMake, and it is added everywhere necessary as a dependency
  • Github Runners now build in NetCDF support!
  • Adds a static, per-file global to the DataProvider (instead of all catchments standing up their own instance)
  • Refactors the "well known fields" code from CsvPerFeatureForcingProvider out of that class and reuses it in NetCDFPerFeatureDataProvider, so it can recognize both "typical" field names from the CSV datasets and translate them to our common CSDMS names (nc files could also have the CSDMS names as the variable names).
  • Small change to csv2catchmentnetcdf.py to allow specifying number of parallel workers with -j... necessary to make a file with less than 96 catchments.

Testing

  1. Updated existing tests for new file/values... I had to increase the assertion tolerance for FP values and I am not sure why...this may bear some investigation.

Screenshots

Notes

Todos

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

Testing checklist (automated report can be put here)

Target Environment support

  • Linux

@mattw-nws mattw-nws marked this pull request as ready for review July 14, 2022 16:42
donaldwj
donaldwj previously approved these changes Jul 14, 2022
test/forcing/NetCDFPerFeatureDataProvider_Test.cpp Outdated Show resolved Hide resolved
@mattw-nws mattw-nws merged commit 0af9ead into NOAA-OWP:master Jul 19, 2022
@mattw-nws mattw-nws linked an issue Sep 12, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for single source binary forcing files
3 participants