Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve action reliability: try --fix-missing as error suggests #414

Merged

Conversation

mattw-nws
Copy link
Contributor

Added --fix-missing to two apt-get install commands, trying to fix occasional builder/runner issues

Additions

Added --fix-missing to two apt-get install commands

Removals

None

Changes

None

Testing

  1. Runners executing on this pull request

Screenshots

if [ Linux == 'Linux' ]
  then
    sudo apt-get install -y libnetcdf-dev libnetcdff-dev
...
Get:12 http://azure.archive.ubuntu.com/ubuntu focal/universe amd64 libnetcdff-dev amd64 4.5.2+ds-1build2 [264 kB]
Err:3 http://azure.archive.ubuntu.com/ubuntu focal-updates/main amd64 libcurl4-gnutls-dev amd64 7.68.0-1ubuntu2.7
  404  Not Found [IP: 52.147.[21](https://github.com/NOAA-OWP/ngen/runs/6278018777?check_suite_focus=true#step:3:21)9.192 80]
Fetched 48[22](https://github.com/NOAA-OWP/ngen/runs/6278018777?check_suite_focus=true#step:3:22) kB in 0s (12.7 MB/s)
E: Failed to fetch http://azure.archive.ubuntu.com/ubuntu/pool/main/c/curl/libcurl4-gnutls-dev_7.68.0-1ubuntu2.7_amd64.deb  404  Not Found [IP: 52.147.219.192 80]
E: Unable to fetch some archives, maybe run apt-get update or try with --fix-missing?
Error: Process completed with exit code 100.

Notes

Todos

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

Testing checklist (automated report can be put here)

Target Environment support

  • Linux

Copy link
Contributor

@christophertubbs christophertubbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only possible issue I can imagine with this is that it might slow down the install by maybe a second or two, which is a supreme nothing-burger.

This gets my seal of approval.

@christophertubbs christophertubbs merged commit b096668 into NOAA-OWP:master May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants