Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a build error when Python is turned off #404

Merged
merged 4 commits into from
Apr 5, 2022

Conversation

stcui007
Copy link
Contributor

Fixed issue 403. Build successfully. Bmi_Py_Formulation should not be used when python is off.

Additions

Removals

Changes

test/realizations/catchments/Bmi_Multi_Formulation_Test.cpp

Testing

Passed all unit tests.

Screenshots

Notes

Todos

Checklist

  • [x ] PR has an informative and human-readable title
  • [x ] Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • [x ] Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

Testing checklist (automated report can be put here)

Target Environment support

  • [x ] Linux

Copy link
Contributor

@mattw-nws mattw-nws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realized that a related error can happen on line 673 also if Fortran support is turned off instead of Python... see my PR on your branch.

@stcui007
Copy link
Contributor Author

stcui007 commented Apr 4, 2022 via email

Catches similar Fortran issue and improved error messaging.
@mattw-nws mattw-nws self-requested a review April 5, 2022 17:06
@mattw-nws mattw-nws merged commit 44e0bce into NOAA-OWP:master Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure ngen builds and behaves as expected with Python support disabled
2 participants