validate number of aorc columns before reading. fixes #372

[hellkite500]

Give appropriate error message when using default forcing provider with incorrect file structure.

Changes

• minimal validation of data in Forcing::read_forcing_aorc

Testing

1. Added unit test to test/forcing/Forcing_test.cpp
2. All tests passing locally

Checklist

• PR has an informative and human-readable title
• Changes are limited to a single goal (no scope creep)
• Code can be automatically merged (no conflicts)
• Code follows project standards (link if applicable)
• Passes all existing automated tests
• Any change in functionality is tested
• New functions are documented (with a description, list of inputs, and expected output)
• Placeholder code is flagged / future todos are captured in comments
• Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
• Reviewers requested with the Reviewers tool ➡️

Target Environment support

• Linux
• MacOs

[donaldwj]

No problems I can see

[stcui007]

In Forcing.h, line 655:
if( header.size() != 10 ){
This assume number of columns is fixed at 10. Is it possible to make it more general?

[hellkite500]

In Forcing.h, line 655: if( header.size() != 10 )

@stcui007
Not in this case, because this particular parser is expecting exactly this number of columns, the parsing of the vector reads exact indicies.

Ultimately, this class will likely become deprecated. I added this fix because if you aren't careful, it is possible to try to load a CSV file using this parser, and not the more generic one, in which case you get seg-faults without any useful warnings, errors, or indications as to what went wrong.

[stcui007]

Good for me.