minor bug fix in JREGIONAL_RUN_PYTHON_GRAPHICS for RTMA #414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guoqing-noaa
requested review from
christinaholtNOAA,
chunhuazhou,
CurtisAlexander-NOAA,
hu5970,
JeffBeck-NOAA,
terraladwig,
TrevorAlcott-NOAA and
daviddowellNOAA
as code owners
terraladwig
reviewed
Aug 3, 2022
Good question. For the cases you mentioned, I think we need modifications inside the python graphic packages. That would be a better way to handle this situation. Looking forward to @christinaholtNOAA's inputs. |
guoqing-noaa
changed the title
|
We need this fix to get the RTMA workflow run through. I just limited the bug fix to RTMA since RTMA will not do any meaningful forecasts in the foreseeable future. @terraladwig Does this work for you? |
|
@guoqing-noaa Do you still need this bug fix? |
|
Yes, RTMA still needs this bug fix. Thanks! |
|
Can anyone help to review this PR? It has already sat here for 19 days. |
hu5970
approved these changes
Aug 22, 2022
|
Thanks, @hu5970 |
guoqing-noaa
pushed a commit
to guoqing-noaa/regional_workflow
that referenced
this pull request
Sep 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When fcst_length is NOT an integer (e.g. sub-hourly), it will stop the graphic workflow. This PR adds a floor()-like function to ensure fcst_length is an integer.