Skip to content

Conversation

@fmalatino
Copy link
Contributor

Description
This PR introduces changes that will enable cFMS to be installed alongside pyFMS as a conda package. This branch is for demonstration only as the cFMS package information is only hosted locally for developers at this time, once the package is hosted on the NOAA-GFDL conda channel this PR will be amended to make use of that channel.

This PR also removes cFMS as a submodule of pyFMS, relying solely on the conda package. All needed files from cFMS will be installed within the conda environment that pyFMS is installed into, and will no longer require explicit paths for locating these files as they will be added to the conda environment's respective lib and include directories.

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also note
any relevant details for your test configuration (e.g. compiler, OS). Include
enough information so someone can reproduce your tests.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant