Skip to content

Conversation

@jjuyeonkim
Copy link
Collaborator

@jjuyeonkim jjuyeonkim commented Apr 22, 2025

Description

This PR contains some initial steps in porting a Fortran shallow water test to pace. This PR will test DycoreState initialization for the Rossby-Haurwitz wave 4 test case found in tools/test_cases.F90 (shallow-water test 6) of the GFDL_atmos_cubed_sphere repo. It also contains an example configuration yaml with a new boolean parameter sw_dynamics in the Dycore configuration.

This PR is dependent on PyFV3 #50 and NOAA-GFDL/NDSL#136

Fixes # (issue)
None.

How Has This Been Tested?
There's a new unit test that uses net-cdf files generated from the SHiELD as ground truth for the initialized DycoreState. It can be run in the following way:

pytest -vsx tests/main/fv3core/test_dycore_rossby_init.py

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation - Not applicable
  • My changes generate no new warnings - There are some new warnings (division by 0) in the unit test.
  • Any dependent changes have been merged and published in downstream modules - This PR is dependent on PyFV3 #50 and Adding sw_dynamics to NamelistDefaults NDSL#136
  • New check tests, if applicable, are included

@jjuyeonkim jjuyeonkim marked this pull request as draft May 23, 2025 19:17
@jjuyeonkim jjuyeonkim changed the title Rossby Test Case Initialization + Example Config [On-hold] Rossby Test Case Initialization + Example Config Jul 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant