Skip to content

Conversation

@ilaflott
Copy link
Member

this PR takes hard-coded values/args/assumptions of fre/cmor/cmor_mixer.py and attempts to make it less dependent on such "hidden configuration".

…in new optional argument for additional control over file targeting. we also now have a \"run one file only\" style flag. new test config file fre/tests/test_files/CMORbite_var_list.json contains variables for processing test cases being workd through in run_test_file_cases.py with notes
…e code currently relies on. unsure how useful the exact way i wrote things down is, but im hoping ot leverage it for structure and or setting up some formulaic approaches and or rules. additionally, merge multiline printstateaments into one call using legal but maybe awkward looking multiline syntax, some other readability edits too
@ilaflott ilaflott added documentation Improvements or additions to documentation new functioning New feature or request priority: MEDIUM labels Oct 28, 2024
@ilaflott ilaflott self-assigned this Oct 28, 2024
@ilaflott ilaflott linked an issue Oct 30, 2024 that may be closed by this pull request
@ceblanton
Copy link
Collaborator

This looks like a quiet PR for a couple days. Is it ready for review?

@ilaflott
Copy link
Member Author

ilaflott commented Nov 5, 2024

draft PR status is "Hold" for now while we get other priorities/capabilities/issues straightened out.

@ilaflott ilaflott added clean up discussion Discuss an issue and it's solutions labels Nov 15, 2024
@ilaflott ilaflott closed this Jan 10, 2025
@ilaflott
Copy link
Member Author

# ----- \start consts
DEBUG_MODE_RUN_ONE = True

#
INPUT_READ_PS_FILE_VAR_NAME = 'ps'
OUTPUT_TEMP_DIR_NAME = 'tmp'

#
INPUT_READ_TAG_OCEAN_GRID_VAR = 'xh'
INPUT_READ_Z_AXIS_NAME = 'Z'

#
INPUT_READ_LAT_DIM = 'lat'
INPUT_READ_LAT_BNDS = 'lat_bnds'
INPUT_READ_LON_DIM = 'lon'
INPUT_READ_LON_BNDS = 'lon_bnds'
INPUT_READ_TIME_DIM = 'time'
INPUT_READ_TIME_BNDS = 'time_bnds'

#
INPUT_READ_AP_ZFACTS = ['ap','ap_bnds']
INPUT_READ_B_ZFACTS = ['b','b_bnds']

#
OUTPUT_WRITE_AXIS_LEVELS_NAME="alternate_hybrid_sigma"
OUTPUT_WRITE_AP_ZFACTS_NAME = "ap"
OUTPUT_WRITE_B_ZFACTS_NAME = "b"

#
OUTPUT_WRITE_AXIS_LEVELS_HALF_NAME="alternate_hybrid_sigma_half"
OUTPUT_WRITE_AP_ZFACTS_HALF_NAME = "ap_half"
OUTPUT_WRITE_B_ZFACTS_HALF_NAME = "b_half"

#
INPUT_ACCEPT_VAR_DIMS = [3,4]
INPUT_ACCEPT_VERT_DIMS = ['plev30', 'plev19', 'plev8','height2m', 'level', 'lev', 'levhalf']

#
OUTPUT_PS_VAR_NAME = 'ps'
OUTPUT_PS_VAR_UNIT = 'Pa'

here's the bit i cared about, it's also in the issue.

@ilaflott ilaflott deleted the fre-cmor-config-exposed branch February 19, 2025 16:26
@ilaflott ilaflott removed documentation Improvements or additions to documentation new functioning New feature or request discussion Discuss an issue and it's solutions clean up priority: MEDIUM labels Jun 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

notes and extracted hard-coding of fre/cmor/cmor_mixer.py make fre.cmor.cmor_mixer more configurable and less hard-code dependent

2 participants