-
Notifications
You must be signed in to change notification settings - Fork 2
Prototype separate workflow for testing Docker build #63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #63 +/- ##
=======================================
Coverage 64.80% 64.80%
=======================================
Files 28 28
Lines 6469 6469
=======================================
Hits 4192 4192
Misses 2277 2277
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: ilaflott <6273252+ilaflott@users.noreply.github.com>
7aebee7 to
8d92e5e
Compare
Removed redundant pull_request trigger and workflow_dispatch from the GitHub Actions configuration.
|
Co-authored-by: ilaflott <6273252+ilaflott@users.noreply.github.com>
Split the
|
|
@copilot note that there's a typo in the |
Co-authored-by: ilaflott <6273252+ilaflott@users.noreply.github.com>
... Fixed in commit 36a4dff:
|
|
… -it Co-authored-by: ilaflott <6273252+ilaflott@users.noreply.github.com>
Fixed in commit 92eff25. The issue was that Added |
|
@copilot you need a |
Co-authored-by: ilaflott <6273252+ilaflott@users.noreply.github.com>
Added in commit 3b5501c. The error was |
|
Co-authored-by: ilaflott <6273252+ilaflott@users.noreply.github.com>
Implemented Docker-in-Docker approach in commit 273f924. Changes:
This follows the standard DinD pattern for GitHub Actions where nested Docker operations need |
Describe your changes
Adds
.github/workflows/docker_build_test.ymlto prototype testing themake releaseDocker-based build process using a Docker-in-Docker (DinD) approach.docker:dindservice with--privilegedflag for proper nested Docker operationsDOCKER_HOST=tcp://localhost:2375to connect workflow steps to the DinD serviceubuntu-latestrocky-8OS targetDOCKER_RUN_OPTSto remove-itflags for non-interactive CIpermissions: contents: readfor securityEach step from the
make releasetarget runs as a separate workflow step for better visibility:If any step fails (including Docker builds), the workflow will fail at that specific step, making it easier to diagnose issues.
Docker-in-Docker (DinD) Approach
The workflow uses a proper DinD approach with a privileged Docker service:
docker:dindservice with--privilegedflag to run a Docker daemon in a privileged containerMakefile Fixes
CONFIG_PAPIEX_DEBUG=$(CONFIG_PAPIEX_DEBUG)andOS_TARGET=$(OS_TARGET)DOCKER_RUN_OPTSto the papiex make command to support non-interactive Docker runs in CIIssue ticket number, link (if applicable)
Checklist
A loose guide to provide structure for contributions
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.