-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for multiple output grids #176
Support for multiple output grids #176
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use mpp_error (NOTE, ...) in place of direct write statements. The different levels of mpp_error notification are NOTE, WARNING, and FATAL. A NOTE is written by the root_pe (master in many cases), WARNING is a note written by all pes, and a FATAL is a WARNING that terminates execution the after the error message is written.
Done. See 9d1fabc But I still see a lot of debug prints not using mpp_error (NOTE, ...), for example:
All these lines not starting with |
@DusanJovic-NOAA - In general messages we want to be easily found and are
purely character data will go through FMS message handling. File
manipulation during initialization, is one of the areas where we want to
the NOTE prefix as it's easy to miss input files during the workdir
creation.
For messages outputting non-character data, direct write statements are
okay. As for messages from other components, they will have their own
standards.
|
Ready for merge. All UFS regression tests finished successfully on all supported platforms. |
@junwang-noaa This PR is ready to merge. Do you want me to add this to the commit queue prior to merging? |
@laurenchilutti Sorry, it may not be clear. The related ufs-weather-model PR has already been in the commit queue (https://github.com/ufs-community/ufs-weather-model/wiki/Commit-Queue). Currently all RT tests passes and code review is done for dycore, fv3atm and ufs-weather-model. Now we will commit the code starting from this PR. Would you please merge the PR? Thanks. |
@junwang-noaa It has been merged. Thank you for explaining. |
Description
fv3atm needs to be updated to support multiple output grids (parent, either global or regional, and any number of nests) using the write grid component. In order to be able to identify which domain is currently running on a given set of PETs, dycore needs to provide total number of domains (grids) and current grid on a given PET.
This PR adds new function (
get_nth_domain_info
) and also returnsngrids
(total number of grids/domains) andmygrid
fromatmosphere_domain
routine.Fixes # (issue)
How Has This Been Tested?
ufs-weather-model has been run on hera.
Checklist:
Please check all whether they apply or not