Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding cell-methods call back for area diagnostics in fv_diagnostics.F90 #166

Merged
merged 1 commit into from
Nov 30, 2021
Merged

Adding cell-methods call back for area diagnostics in fv_diagnostics.F90 #166

merged 1 commit into from
Nov 30, 2021

Conversation

laurenchilutti
Copy link
Contributor

@laurenchilutti laurenchilutti commented Nov 29, 2021 •
edited
Loading

Description

This call was previously in the code and was removed. This PR brings the line back.

Fixes #165

How Has This Been Tested?

I have not tested this.

Checklist:

Please check all whether they apply or not

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

lharris4
lharris4 approved these changes Nov 29, 2021
View reviewed changes
Copy link
Contributor

@lharris4 lharris4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me. (I don't think this isolated one-line change needs three reviews.)

@laurenchilutti laurenchilutti merged commit 10f21e7 into NOAA-GFDL:dev/gfdl Nov 30, 2021
laurenchilutti added a commit that referenced this pull request Nov 30, 2021
@laurenchilutti
adding back a line that was mistakenly deleted in a previous commit (#…
c885c3e 
…166)
laurenchilutti added a commit that referenced this pull request Nov 30, 2021
@laurenchilutti
adding back a line that was mistakenly deleted in a previous commit (#…
fa86482 
…166)
MinsukJi-NOAA added a commit to NOAA-EMC/GFDL_atmos_cubed_sphere that referenced this pull request Mar 2, 2022
@MinsukJi-NOAA @DusanJovic-NOAA
@laurenchilutti @jswhit @jswhit2 @MatthewPyle-NOAA
Update to the latest noaa-gfdl dev/emc branch (#69)
c0d57b9 
* Add get_nth_domain_info subroutine

* Deallocate local arrays in fv_dyn_bundle_setup

* adding back a line that was mistakenly deleted in a previous commit (NOAA-GFDL#166)

* Do not print debug messages to stderr

* fix for 4diau with iau_filter_increments=T (NOAA-GFDL#167)

* fix for 4diau with iau_filter_increments=T

* fix time interval for 3DIAU

* fix typo in comment

* fix bug found in review by @MingjingTong-NOAA

* change tnext to integer variable itnext

Co-authored-by: jswhit2 <Jeffrey.S.Whitaker@noaa.gov>

* Use mpp_error instead of write statements in model/fv_regional_bc.F90

* Attempt at integrating fixes on top of dev/emc branch. (NOAA-GFDL#173)

Co-authored-by: Dusan Jovic <dusan.jovic@noaa.gov>
Co-authored-by: laurenchilutti <60401591+laurenchilutti@users.noreply.github.com>
Co-authored-by: Jeff Whitaker <jswhit@fastmail.fm>
Co-authored-by: jswhit2 <Jeffrey.S.Whitaker@noaa.gov>
Co-authored-by: MatthewPyle-NOAA <48285220+MatthewPyle-NOAA@users.noreply.github.com>
MinsukJi-NOAA added a commit to NOAA-EMC/GFDL_atmos_cubed_sphere that referenced this pull request Mar 30, 2022
@MinsukJi-NOAA @DusanJovic-NOAA
@laurenchilutti @jswhit @jswhit2 @MatthewPyle-NOAA @MicroTed @LarissaReames-NOAA
Update to the latest GFDL dev/emc (#70)
19792ad 
* Add get_nth_domain_info subroutine

* Deallocate local arrays in fv_dyn_bundle_setup

* adding back a line that was mistakenly deleted in a previous commit (NOAA-GFDL#166)

* Do not print debug messages to stderr

* fix for 4diau with iau_filter_increments=T (NOAA-GFDL#167)

* fix for 4diau with iau_filter_increments=T

* fix time interval for 3DIAU

* fix typo in comment

* fix bug found in review by @MingjingTong-NOAA

* change tnext to integer variable itnext

Co-authored-by: jswhit2 <Jeffrey.S.Whitaker@noaa.gov>

* Use mpp_error instead of write statements in model/fv_regional_bc.F90

* Attempt at integrating fixes on top of dev/emc branch. (NOAA-GFDL#173)

* Support for cloud microphysics hail species (NOAA-GFDL#171)

* Incorporated Tim Supinie's updates to handle a hail category (nwat=7)

* Added print for hail max/min (non-debug section)

* Add hallwat to !OMP shared variables in main loop

Addresses compile failure when OMP is turned on (e.g., on Hera)

* Update to states as used in SFE2021
(Removed SFE code for now)

* Cleanup after rebase

* Redo removal of alt. namelist read

* Removed tools/module_diag_hailcast.F90

* Fixes from Jili Dong

* Add hailwat to tools/external_ic.F90

* Set logic in fv_regional_bc.F90 to match current code; Change logic in external_ic.F90 to check value of nwat

* Recommended changes

* Check actual index (hailwat) instead of assuming a positive value based on 'nwat' value

* Split nwat=7 bits into separate loops (see if it affects nwat=6)

Co-authored-by: Larissa Reames <52886575+LarissaReames-NOAA@users.noreply.github.com>
Co-authored-by: LarissaReames-NOAA <larissa.reames@noaa.gov>

Co-authored-by: Dusan Jovic <dusan.jovic@noaa.gov>
Co-authored-by: laurenchilutti <60401591+laurenchilutti@users.noreply.github.com>
Co-authored-by: Jeff Whitaker <jswhit@fastmail.fm>
Co-authored-by: jswhit2 <Jeffrey.S.Whitaker@noaa.gov>
Co-authored-by: MatthewPyle-NOAA <48285220+MatthewPyle-NOAA@users.noreply.github.com>
Co-authored-by: Ted Mansell <37668594+MicroTed@users.noreply.github.com>
Co-authored-by: Larissa Reames <52886575+LarissaReames-NOAA@users.noreply.github.com>
Co-authored-by: LarissaReames-NOAA <larissa.reames@noaa.gov>
laurenchilutti added a commit that referenced this pull request Oct 13, 2022
@laurenchilutti @bensonr
@menzel-gfdl @MatthewPyle-NOAA @lharris4 @MicroTed
Dev/gfdl test (#222)
721e6f7 
* updated fv_regional_bc.F90 to read levsp from GFS_ctl file (#152)

* Updating a continue statement in fv_nudge (#153)

* update in fv_nudge to fix 666 label logic

* fix logic errors (#138)

* update to external_ic::remap_scale to skip remapping non-existent IC tracers (#159)

* Fix nudge logic (#157)

* fix logic errors

* fix answer changes

* adding back a line that was mistakenly deleted in a previous commit (#166)

* Release 042022 (#184)

* Merge of updates from GFDL Weather and Climate Dynamics Division (202204):

    *add license header to missing files and fix typo in header

    *updates needed for fv3_gfsphysics to have access to bounded_domain

    *remove obsoleted driver/SHiELD files

    *updating to fix bug where long_name and units attributes were not being captured in the RESTARTS

    *remove unused function fv_diagnostics::max_vorticity_hy1

    *remove avec timer remnants

    *adding ability to specify prefix and directory when reading and writing restarts

    *remove old style namelist read in favor of read from internal character variable

    *Added option for a mean wind

    *The planetary radius and rotation rate are now re-scalable by a namelist parameter (small_earth_scale) instead of using exclusively the hard-coded FMS constant.

    *fv_mapz: Cleanup and added helpful annotations to avoid getting lost so easily

    * remove duplicate code and fix lstatus on all grids depending on gfs_data and gfs_data.tile1

    * New idealized tests

    *Makes the non-hydrostatic restart variables optional for reads to allow hydrostatic ICs

    *Fix the hydrostatic TE remapping; Add GMAO cubic for TE remapping, which is used if kord_tm=0 and remap_te=.true.

    *Add a TE remapping option (kord_tm=0)

    *Addressing GNU Warnings

    *Add the L75 vertical config from HAFS

    * clean up fms_mp_mod and remove mp_bcst

* cherry pick 5193c6b from dev/emc

* Attempt at integrating fixes on top of dev/emc branch. (#173)

* remove outdated GFDL_tools/fv_diag_column.F90 which exists as the result of an improper merge.  The correct file is tools/fv_diag_column.F90 (#191)

* various io fixes (#192)

* fixes io performance issues by making everyone a reader when io_layout=1,1

adds capability to use FMS feature to ignore data integrity checksums in restarts

* rename enforce_rst_cksum to ignore_rst_cksum and change the default value for compatibility

* fix index error (#196)

* New notebooks (#190)

* Moving source files into source directory

* Added advection notebook

* Fixed subplot spacing

* New 3D case notebooks

* New idealized tests

Updated mtn_wave_tests_1km to restore missing graphics.

* first try at held-suarez

* Updated H-S superrotation notebook

* New level placement tool in an interactive note

* Minor updates to notebooks; deleted fv_eta binary.

* Regional decomposition test fix (when nrows_blend > 0) (#194) (#200)

* Regional bc blend changes to extend into interior halos and overlap on corners. Still not working for u and v.

dyn_core.F90 : Fix from Jun Wang to correct sync of u,v
fv_regional_bc.F90 : add check for nrows_blend > tile size; fix error when nrows_blend=1

Conflicts (not taken during chery-pick):
	driver/SHiELD/atmosphere.F90
	model/fv_sg.F90

Co-authored-by: Ted Mansell <37668594+MicroTed@users.noreply.github.com>

* Implementing CI (#207)

* CI Parallelworks update (#211)

* Update call to read_input_nml and remove unnecessary code. (#161)

* Removing use of INTERNAL_FILE_NML and cleaning up read_namelist_test_cases to remove unused argument

* deleting duplicate call to read_namelist_test_case_nml in fv_control

* removing commented code in fv_control

Co-authored-by: Rusty Benson <6594772+bensonr@users.noreply.github.com>
Co-authored-by: menzel-gfdl <43218622+menzel-gfdl@users.noreply.github.com>
Co-authored-by: Rusty Benson <Rusty.Benson@noaa.gov>
Co-authored-by: MatthewPyle-NOAA <48285220+MatthewPyle-NOAA@users.noreply.github.com>
Co-authored-by: lharris4 <53020884+lharris4@users.noreply.github.com>
Co-authored-by: Ted Mansell <37668594+MicroTed@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikizadehgfdl nikizadehgfdl nikizadehgfdl approved these changes

@bensonr bensonr bensonr approved these changes

@lharris4 lharris4 lharris4 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@laurenchilutti @nikizadehgfdl @bensonr @lharris4