Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better error message from CCPP in case call to ccpp_physics_run for group 'fast_physics' failed #148

Merged

Conversation

climbfuji
Copy link

@climbfuji climbfuji commented Oct 4, 2021

Description

As the title says: Better error message from CCPP in case call to ccpp_physics_run for group 'fast_physics' failed. Without this change, the actual error message that is written to cdata%errmsg by the physics is not written to stderr and then user only gets "Call to ccpp_physics_run for group 'fast_physics' failed".

How Has This Been Tested?

ufs-weather-model regression tests (see ufs-community/ufs-weather-model#850)

Associated PRs:

NCAR/ccpp-physics#749
NCAR/ccpp-framework#404
#148
https://github.com/NOAA-EMC/fv3atm/pull/407/files
NOAA-PSL/stochastic_physics#48
ufs-community/ufs-weather-model#850

Checklist:

Please check all whether they apply or not

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • [n/a] I have commented my code, particularly in hard-to-understand areas
  • [n/a] I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • [n/a] Any dependent changes have been merged and published in downstream modules

@climbfuji
Copy link
Author

@bensonr If you think this is a good idea, I can pull #146 into this PR.

@bensonr
Copy link
Contributor

bensonr commented Oct 5, 2021

I don't think it's necessary. They both touch different files, so there is no need to bundle them together. I am mostly waiting for reviews for the various PRs that have come in recently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants