Possible bug in fv_grid_tools.f90 #38
Comments
|
Hi, Oliver. Indeed the last index should be n.
Thanks,
Lucas
…On Thu, Apr 30, 2020 at 5:05 AM Oliver Fuhrer ***@***.***> wrote:
The code here
<https://github.com/NOAA-GFDL/GFDL_atmos_cubed_sphere/blob/75b6ba3519dc91092ca8bcf409493a4182fa5712/tools/fv_grid_tools.F90#L620>
ln L620-621 is...
if (ABS(grid_global(i,j,1,1)) < 1.d-10) grid_global(i,j,1,1) = 0.0 if
(ABS(grid_global(i,j,2,1)) < 1.d-10) grid_global(i,j,2,1) = 0.0
...and should probably be...
if (ABS(grid_global(i,j,1,n)) < 1.d-10) grid_global(i,j,1,n) = 0.0 if
(ABS(grid_global(i,j,2,n)) < 1.d-10) grid_global(i,j,2,n) = 0.0
...or taken out of the loop over regions.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#38>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AMUQRVFKZ2RT4VASFOGCR3TRPE5OZANCNFSM4MVKMMZQ>
.
|
|
See PR39. Note that I can't assign reviewers to PR's. |
climbfuji
pushed a commit
to climbfuji/GFDL_atmos_cubed_sphere
that referenced
this issue
Oct 1, 2020
Merge dev/emc branch from upstream (NOAA-GFDL/GFDL_atmos_cubed_sphere)
Merged
climbfuji
pushed a commit
to climbfuji/GFDL_atmos_cubed_sphere
that referenced
this issue
Apr 24, 2024
…nhydrostatic-build Updates to allow for building FV dynamics as non-hydrostatic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The code here on L620-621 in fv_grid_tools.f90 is...
if (ABS(grid_global(i,j,1,1)) < 1.d-10) grid_global(i,j,1,1) = 0.0 if (ABS(grid_global(i,j,2,1)) < 1.d-10) grid_global(i,j,2,1) = 0.0...and should probably be...
if (ABS(grid_global(i,j,1,n)) < 1.d-10) grid_global(i,j,1,n) = 0.0 if (ABS(grid_global(i,j,2,n)) < 1.d-10) grid_global(i,j,2,n) = 0.0...or taken out of the loop over regions.
The text was updated successfully, but these errors were encountered: