Remove unused components - fft, station_data, diag_manager/diag_manifest.F90 #199
Conversation
Update how configure.ac checks for the netcdf headers and libraries. This now properly checks for C, C++, Fortran and Fortran 77 headers and APIs.
Adding in the m4 macros that will check for netcdf. Includes several Fortran specific tests.
Update configure.ac to correctly check for and if needed add options to build libFMS. This includes cray pointers, netcdf, mpi, long lines, etc.
Fix a few syntax errors in the configure.ac script to correctly handle all configure options Expand the travis CI tests to test additional options
Fixed how the travis tests are configured
Added the missing compiler flags for the disable-setting-flags build.
Corrected a m4 macro that did not restore the FCFLAGS after running the tests.
Add package config file FMS.pc to be included when libFMS is installed.
Fixed the use of the wrong absolute value function in C sources
The automake build had a circular dependency on mpp_efp.o and the mpp_efp_mod.mod file. This has been removed.
Removed unused parts of the FMS library. These include station data (an early single point regional output) and diag_manifest.F90.
Finshed removing mention of diag_manifest.F90 and its module.
Remove the remainder station_data portions from Makefiles.
Remove fft as it is not used in current GFDL models.
wrongkindofdoctor
added
development
enhancement
|
@underwoo this pull request does much more than what the description implies. For example, I looked at the travis build with the option |
|
@thomas-robinson it does. This PR needs to be taken after #181. I should have said that in the description. |
|
Thank you for pointing this out. It appears the Note, the first build of FMS does honor the |
underwoo
changed the title
|
@underwoo I can merge this in as soon as you resolve the merge conflicts. |
|
@underwoo I looked at the conflict in diag_manager and it's on line 232/233. You want manually fix this one. 232 & max_file_attributes, max_axis_attributes, prepend_date, DIAG_FIELD_NOT_FOUND, diag_init_time, diag_data_init,&
233 & write_manifest_file, fileobj, fileobjU, fnum_for_domain, fileobjNDYou removed the |
Resolve merge conflicts to allow remove.unused.components to be merged into master.
This is to clean up when the template is used.
Changed per suggested use of --with- vs --enable- in configure.
Removed some components not used in current GFDL models. These include:
This PR should only be taken after #181.