Skip to content

Fix divide by zero in time_manager#1898

Open
rickgrubin-noaa wants to merge 1 commit into
NOAA-GFDL:mainfrom
rickgrubin-noaa:bugfix/time_manager
Open

Fix divide by zero in time_manager#1898
rickgrubin-noaa wants to merge 1 commit into
NOAA-GFDL:mainfrom
rickgrubin-noaa:bugfix/time_manager

Conversation

@rickgrubin-noaa

Copy link
Copy Markdown

Description

Add flags -fp-model=precise -fp-speculation=safe for Intel OneAPI Fortran ifx

Fixes #1891

No dependencies required for this change.

How Has This Been Tested?

Testing:

  • modifying the spack-packages recipe for FMS to inject flags -fp-model=precise -fp-speculation=safe into the package build. Subsequent UFS WM regression tests succeed / do not generate divide-by-zero errors.
  • re-created Dusan Jovic's reproducer test, and build / ran it against the updated spack-stack build noted above. See: /gpfs/f6/epic/scratch/Richard.Grubin/test_time_manager
    • compare with: /gpfs/f6/drsa-hurr1/scratch/Dusan.Jovic/ufs/ss210/test_time_manager
    • for both reproducer tests: run build.sh
  • cloned my repository fork for the bugfix branch
    • configured and executed a cmake build
    • ran tests for time_manager

Host / compiler info:

  • Host: gaea-c6
  • OS
% cat /etc/os-release
NAME="SLES"
VERSION="15-SP6"
VERSION_ID="15.6"
PRETTY_NAME="SUSE Linux Enterprise Server 15 SP6"
ID="sles"
  • Compiler: Intel oneAPI@2025.2.1

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included
  • make distcheck passes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Divide by zero error in time_manager with ifx 2025.2.1 in debug mode

2 participants