modern diag manager: correctly adds the associated_files attribute #1451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… diag_send_complete calls
This reverts commit 8738f23.
uramirez8707
commented
Feb 7, 2024
| subroutine generate_associated_files_att(this, att, start_time) | ||
| class(fmsDiagField_type) , intent(in) :: this !< diag_field_object for the area/volume field | ||
| character(len=*), intent(inout) :: att !< associated_files_att | ||
| type(time_type), intent(in) :: start_time |
rem1776
pushed a commit
to rem1776/FMS
that referenced
this pull request
May 1, 2024
rem1776
pushed a commit
to rem1776/FMS
that referenced
this pull request
May 1, 2024
rem1776
pushed a commit
to rem1776/FMS
that referenced
this pull request
May 1, 2024
rem1776
pushed a commit
to rem1776/FMS
that referenced
this pull request
May 1, 2024
rem1776
pushed a commit
to rem1776/FMS
that referenced
this pull request
May 1, 2024
rem1776
pushed a commit
to rem1776/FMS
that referenced
this pull request
May 1, 2024
rem1776
pushed a commit
to rem1776/FMS
that referenced
this pull request
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix to correctly add the associated files attribute
Fix to ignore diag files that don't have any fields, to reproduce old behavior
Remove the limit to the number of subaxis ids allowed
Set the
current_model_timeinsend_datainstead ofdiag_send_completeFixes # (issue)
How Has This Been Tested?
CI including the new test
Checklist:
make distcheckpasses