Mixed precision axis_utils2 #1081
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcallic2
requested review from
bensonr,
thomas-robinson and
rem1776
as code owners
mcallic2
changed the title
Conflicts: axis_utils/include/axis_utils2.inc
mlee03
reviewed
Dec 14, 2022
| write (unit,*) '=> Error: "nearest_index" array must be monotonically increasing & | ||
| &when searching for nearest value to ',value | ||
| write (unit,*) '=> Error: "nearest_index" array must be monotonically increasing' & | ||
| & // 'when searching for nearest value to ', value |
There was a problem hiding this comment.
I believe the \\ are for the gcc compiler to understand the string concatanation
mlee03
reviewed
Dec 20, 2022
axis_utils/include/axis_utils2.inc
Outdated
| keep_going = .true. | ||
| do while (i <= ia .and. keep_going) | ||
| i = i+1 | ||
| if (value <= array(i)) then | ||
| frac_index = float(i-1) + (value-array(i-1))/(array(i)-array(i-1)) | ||
| keep_going = .false. | ||
| FRAC_INDEX_ = float(i-1) + (value-array(i-1))/(array(i)-array(i-1)) |
There was a problem hiding this comment.
instead of float, real(i-1,FMS_AI_KIND_)
| @@ -26,7 +26,7 @@ program test_axis_utils | |||
| use axis_utils2_mod, only : axis_edges | |||
| use fms2_io_mod, only : open_file, close_file, write_data, register_axis, register_field, & | |||
| FmsNetcdfFile_t, register_variable_attribute | |||
| use platform_mod, only : r8_kind | |||
| use platform_mod, only : r4_kind, r8_kind | |||
There was a problem hiding this comment.
You do not need the test_axis_utils.F90 file and should be deleted?
BREAKING CHANGE: The following namelist flags are deprecated and will now result in a fatal error if used: grid_center_bug, read_data_bug, retain_cm3_bug, and reproduce_siena
|
@mcallic2 I think you pulled from |
|
I messed up pulling in main on this PR. I created a new PR to hide my shame, please refer to that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds all changes needed for axis_utils2 to add mixed mode precision
Fixes # (issue)
How Has This Been Tested?
Autotools using oneapi and gcc compiler, and cmake
Checklist:
make distcheckpasses