Update global-workflow scripts for runnng the NG-GODAS application #995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parm/config/config.base.emc.dyn parm/config/config.coupled_ic ush/rocoto/setup_expt.py ush/rocoto/setup_workflow_fcstonly.py
…rkflow into add_NG_GODAS
parm/config/config.base.emc.dyn parm/config/config.coupled_ic ush/rocoto/setup_expt.py ush/rocoto/setup_workflow_fcstonly.py
* update parm/config/config.defaults.datm * update ush/rocoto/setup_workflow_fcstonly.py
WalterKolczynski-NOAA
requested changes
Aug 25, 2022
| @@ -23,6 +23,87 @@ common_predet(){ | |||
| } | |||
|
|
|||
| DATM_predet(){ | |||
| echo "SUB ${FUNCNAME[0]}: Defining variables for datm" | |||
There was a problem hiding this comment.
How much of this is duplicate code of FV3_GFS_predet() that could be abstracted out into a separate function that is called for both cases?
| @@ -282,7 +282,49 @@ if [ $type = "gfs" ]; then | |||
| fi ##end of gfs | |||
| #----------------------------------------------------- | |||
|
|
|||
| if [ $ATMTYPE = "DATA" ]; then | |||
| if [ $DO_OCN = "YES" ]; then | |||
There was a problem hiding this comment.
Is this just a duplicate of the other DO_OCN, etc. blocks for GFS? Instead of duplicating, can we restructure so those sections are used in both cases?
| @@ -9,30 +9,26 @@ | |||
| ## writing model configure file for DATM | |||
| ## This script is a direct execution. | |||
| ##### | |||
|
|
|||
| . $EXPDIR/config.defaults.datm | |||
There was a problem hiding this comment.
This shouldn't be called here. It was already called in config.base.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Although a global-workflow branch at https://github.com/binli2337/global-workflow/tree/add_gefs is available for the NG-GODAS team to do testing for the NG-GODAS (cdeps_datm_mom6_cic6) application, it uses previous workflow-generation scripts located in the ush/rocoto directory.
The above branch has been updated to use new workflow-generation scripts located in the workflow directory. The Python script "workflow_tasks.py" has been updated to use correct forcing files. The global-workflow scripts in ush, scripts and parm/config directories have also been updated for running NG-GODAS application.
Fixes #774
Fixes #785
Fixes #838
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Checklist