Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additions and modifications for EFSOI #674

Closed

Conversation

AndrewEichmann-NOAA
Copy link
Contributor

Issue #673

Description

Changes to files files in parm/config to enable EFSOI (Issue #673)

Files added:

  • config.ecenfsoi
  • config.efcsfsoi
  • config.efsoi
  • config.eposfsoi
  • config.esfcfsoi
  • config.eupdfsoi
    (For their respective EFSOI-specific tasks)

Files changed:
config.base.emc.dyn (addition of commented EFSOI option, to be uncommented to run EFSOI. Leaving it as is will allow setup of regular cycling experiment)
config.earc (addition of variable RMOLDEND_EFSOI to determine how long to retain EFOSI files)
config.resources (addition of blocks for EFSOI tasks)

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Branch has been tested by running regular (non-EFSOI) cycled experiments on Orion and Hera with 20 ensemble members without any changes other than queue specification. Experiments were run for a few cycles with successfully completed tasks.

  • Clone and Build tests on WCOSS Dell P3
  • Cycled test on Orion
  • Cycled test on Hera

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes need updates to the documentation. I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • Any dependent changes have been merged and published

Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found 48 potential problems in the proposed changes. Check the Files changed tab for more details.

Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found 48 potential problems in the proposed changes. Check the Files changed tab for more details.

Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found 48 potential problems in the proposed changes. Check the Files changed tab for more details.

Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found 48 potential problems in the proposed changes. Check the Files changed tab for more details.

Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found 48 potential problems in the proposed changes. Check the Files changed tab for more details.

Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found 48 potential problems in the proposed changes. Check the Files changed tab for more details.

Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found 48 potential problems in the proposed changes. Check the Files changed tab for more details.

Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found 48 potential problems in the proposed changes. Check the Files changed tab for more details.

Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found 47 potential problems in the proposed changes. Check the Files changed tab for more details.

Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found 47 potential problems in the proposed changes. Check the Files changed tab for more details.

Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found 47 potential problems in the proposed changes. Check the Files changed tab for more details.

Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found 46 potential problems in the proposed changes. Check the Files changed tab for more details.

@AndrewEichmann-NOAA
Copy link
Contributor Author

AndrewEichmann-NOAA commented Sep 19, 2022

@WalterKolczynski-NOAA

I've worked through the shellcheck flags and this is what remains:

  • Lines that I hadn't changed - I corrected a number of these, but corrections tend to beget more flags and this thing doesn't need a wider scope
  • Complaints about unassigned variables and non-existing files which are evidently incorrect
  • A couple cases that I think need some outside attention, annotated in reviews above

I've also taken out the config files calling each other, and instead put them in the series of config files sourced at the beginning of jjobs. They should be in line with all the other tasks now.

@AndrewEichmann-NOAA
Copy link
Contributor Author

Superseded by #1074

@AndrewEichmann-NOAA AndrewEichmann-NOAA deleted the feature/EFSOI_A branch October 20, 2022 18:39
kayeekayee pushed a commit to kayeekayee/global-workflow that referenced this pull request May 30, 2024
…MC#674)

* optimized the code and decrease the stratosphere warm bias for mraerosol=T
---------
Co-authored-by: anning.cheng <anning.cheng@noaa.gov>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants