-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Additions and modifications for EFSOI #674
Additions and modifications for EFSOI #674
Conversation
Getting EFSOI branch merged with develop
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found 48 potential problems in the proposed changes. Check the Files changed tab for more details.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found 48 potential problems in the proposed changes. Check the Files changed tab for more details.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found 48 potential problems in the proposed changes. Check the Files changed tab for more details.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found 48 potential problems in the proposed changes. Check the Files changed tab for more details.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found 48 potential problems in the proposed changes. Check the Files changed tab for more details.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found 48 potential problems in the proposed changes. Check the Files changed tab for more details.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found 48 potential problems in the proposed changes. Check the Files changed tab for more details.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found 48 potential problems in the proposed changes. Check the Files changed tab for more details.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found 47 potential problems in the proposed changes. Check the Files changed tab for more details.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found 47 potential problems in the proposed changes. Check the Files changed tab for more details.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found 47 potential problems in the proposed changes. Check the Files changed tab for more details.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found 46 potential problems in the proposed changes. Check the Files changed tab for more details.
I've worked through the shellcheck flags and this is what remains:
I've also taken out the config files calling each other, and instead put them in the series of config files sourced at the beginning of jjobs. They should be in line with all the other tasks now. |
Superseded by #1074 |
…MC#674) * optimized the code and decrease the stratosphere warm bias for mraerosol=T --------- Co-authored-by: anning.cheng <anning.cheng@noaa.gov>
Issue #673
Description
Changes to files files in parm/config to enable EFSOI (Issue #673)
Files added:
(For their respective EFSOI-specific tasks)
Files changed:
config.base.emc.dyn (addition of commented EFSOI option, to be uncommented to run EFSOI. Leaving it as is will allow setup of regular cycling experiment)
config.earc (addition of variable RMOLDEND_EFSOI to determine how long to retain EFOSI files)
config.resources (addition of blocks for EFSOI tasks)
Type of change
How Has This Been Tested?
Branch has been tested by running regular (non-EFSOI) cycled experiments on Orion and Hera with 20 ensemble members without any changes other than queue specification. Experiments were run for a few cycles with successfully completed tasks.
Checklist