Skip to content

Add ush and parm of SPOC #3944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

xincjin-NOAA
Copy link

@xincjin-NOAA xincjin-NOAA commented Aug 14, 2025

Description

This PR resolves issue #3943

This PR adds the capability to process python scripts and yaml files from SPOC (https://github.com/NOAA-EMC/spoc) so that GDASApp can use them to convert observation files into IODA formal.

Type of change

  • Bug fix (fixes something broken)
  • [ x] New feature (adds functionality)
  • Maintenance (code refactor, clean-up, new CI test, etc.)

Change characteristics

  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? NO
  • Does this change require an update to any of the following submodules? YES

How has this been tested?

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have documented my code, including function, input, and output descriptions
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • This change is covered by an existing CI test or a new one has been added
  • Any new scripts have been added to the .github/CODEOWNERS file with owners
  • I have made corresponding changes to the system documentation if necessary

@CoryMartin-NOAA CoryMartin-NOAA added the JEDI Feature development to support JEDI-based DA label Aug 14, 2025
Copy link
Contributor

@CoryMartin-NOAA CoryMartin-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xincjin-NOAA I think we need to include a GDASApp hash change in here

@xincjin-NOAA
Copy link
Author

@CoryMartin-NOAA added here and above:
GDASApp: #261cd47

@xincjin-NOAA
Copy link
Author

@CoryMartin-NOAA Updated the hash for the gdas.cd submodule.

Copy link
Contributor

@CoryMartin-NOAA CoryMartin-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but since it updates GDAS hash, we probably need to wait for other PRs to go in first, like #3798

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JEDI Feature development to support JEDI-based DA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants