Adding workflow infrastructure for wave_stat and wave_stat_pnt jobs #3846
Conversation
sbanihash
requested review from
DavidHuber-NOAA,
KateFriedman-NOAA and
aerorahul
as code owners
|
@aerorahul I closed my previous PR, made a new branch from develop, added my changes from the previous branch , made new commits so that this PR is not 100 commits ahead of develop and is easier to follow, and opened this new PR. Hopefully this makes it easier for you to review. Thank you so much for your time reviewing this work during the past few months. Hopefully we could get this one out soon. |
|
|
||
|
|
||
| ############################################################### | ||
| source "${HOMEgfs}/ush/load_ufswm_modules.sh" |
There was a problem hiding this comment.
Is this intentional? Why not use load_fv3gfs_module.sh?
There was a problem hiding this comment.
@aerorahul tagging you here for the responses, this is mimicking what we have in other wave jobs such as waveinit and wavepost jobs. Let me know if it needs to be reverted to what Kate suggested. (Probably needs same thing for those jobs as well)
| #! /usr/bin/env bash | ||
|
|
||
| ############################################################### | ||
| source "${HOMEgfs}/ush/load_ufswm_modules.sh" |
| @@ -127,6 +127,7 @@ export APP="{{ APP }}" | |||
| export DO_ATM="YES" | |||
| export DO_COUPLED="NO" | |||
| export DO_WAVE="NO" | |||
| export DO_WAVE_STAT="NO" | |||
There was a problem hiding this comment.
This is probably ok here but it's within the major switches for the components (wave, ocean, ice, etc.) so I'm wondering if there is a better place for this in here. @DavidHuber-NOAA thoughts?
There was a problem hiding this comment.
@DavidHuber-NOAA , Rahul had also mentioned the same comment on the previous PR that was closed. Since this switch will add a whole new job to the runs we kept it here. Let me know if you have a better place for it in mind.
| @@ -56,7 +56,7 @@ elif [[ "${step}" = "prep_emissions" ]]; then | |||
| export APRUN="${launcher} -n 1" | |||
|
|
|||
| elif [[ "${step}" = "waveinit" ]] || [[ "${step}" = "waveprep" ]] || [[ "${step}" = "wavepostsbs" ]] || \ | |||
| [[ "${step}" = "wavepostbndpnt" ]] || [[ "${step}" = "wavepostpnt" ]] || [[ "${step}" == "wavepostbndpntbll" ]]; then | |||
| [[ "${step}" = "wavepostbndpnt" ]] || [[ "${step}" = "wavepostpnt" ]] || [[ "${step}" == "wavepostbndpntbll" ]] || [[ "${step}" = "wave_stat" ]]; then | |||
There was a problem hiding this comment.
I don't see the wave_stat_pnt job added in any of the env files.
There was a problem hiding this comment.
I did not add it since I thought this block is only if we need to define USE_CFP, mpmd , mpexec etc., @aerorahul please let me know if this is a misunderstanding.
Co-authored-by: Kate Friedman <kate.friedman@noaa.gov>
Co-authored-by: Kate Friedman <kate.friedman@noaa.gov>
Description
This PR creates the infrastructure for the wave_stat addition into the global workflow. The PR has been modified to only contain the workflow changes needed for the two new jobs: JGEFS_WAVE_STAT and JGEFS_WAVE_STAT_PNT to be added.
After getting this part merged, the next PR (from this branch ) will contain these four scripts:
scripts/exgefs_wave_stat.sh
scripts/exgefs_wave_stat_pnt.sh
and
ush/wave_ens_stat.sh
ush/wave_ens_bull.sh
Type of change
Change characteristics
How has this been tested?
This PR was tested with the second part of the changes pulled in as well. Without that part the functionality can not be tested. Although checking to make sure other ci tests are not effected is needed.
Output from ci test (C48_S2SWA_gefs) with pulling in second part of changes can be found on dogwood:
/lfs/h2/emc/couple/noscrub/saeideh.banihashemi/Dev_Work/GEFS/INFRST/GW-DEV/new/RUNTESTS/COMROOT/wavestat/gefs.20210323/12/ensstat/products/wave
Checklist