Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error log parsing in compute build CI #3301

Merged
merged 10 commits into from
Feb 10, 2025

Conversation

DavidHuber-NOAA
Copy link
Contributor

@DavidHuber-NOAA DavidHuber-NOAA commented Feb 5, 2025

Description

This PR adds a new feature to capture and report which compute builds failed when running CI.

Resolves #3296

Type of change

  • New feature (adds functionality)

Change characteristics

  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? NO
  • Does this change require an update to any of the following submodules? NO

How has this been tested?

  • CI on Hercules

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have documented my code, including function, input, and output descriptions
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • This change is covered by an existing CI test or a new one has been added

@DavidHuber-NOAA DavidHuber-NOAA marked this pull request as draft February 5, 2025 13:50
sorc/build_compute.sh Fixed Show fixed Hide fixed
sorc/build_compute.sh Fixed Show fixed Hide fixed
@DavidHuber-NOAA
Copy link
Contributor Author

Running CI on Hercules to test the new feature.

@DavidHuber-NOAA DavidHuber-NOAA added the CI-Hercules-Ready **CM use only** PR is ready for CI testing on Hercules label Feb 5, 2025
@emcbot emcbot added CI-Hercules-Building **Bot use only** CI testing is cloning/building on Hercules and removed CI-Hercules-Ready **CM use only** PR is ready for CI testing on Hercules labels Feb 5, 2025
@emcbot
Copy link

emcbot commented Feb 5, 2025

Build FAILED on Hercules in Build# 1 with error logs:

/work2/noaa/global/CI/HERCULES/3301/global-workflow/sorc/logs/gdas.log

Follow link here to view the contents of the above file(s): (link)

@emcbot emcbot added CI-Hercules-Failed **Bot use only** CI testing on Hercules for this PR has failed and removed CI-Hercules-Building **Bot use only** CI testing is cloning/building on Hercules labels Feb 5, 2025
@DavidHuber-NOAA
Copy link
Contributor Author

Testing on Hercules shows that these changes successfully triggers the creation of a gist with the failed log file. Marking this PR as ready for review.

@DavidHuber-NOAA DavidHuber-NOAA marked this pull request as ready for review February 5, 2025 14:31
@DavidHuber-NOAA DavidHuber-NOAA changed the title DO NOT MERGE Test error log parsing in compute build CI Fix error log parsing in compute build CI Feb 5, 2025
@DavidHuber-NOAA DavidHuber-NOAA removed the CI-Hercules-Failed **Bot use only** CI testing on Hercules for this PR has failed label Feb 5, 2025
Copy link
Collaborator

@TerrenceMcGuinness-NOAA TerrenceMcGuinness-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I saw the error logs showed up and got stored in the Jenkins Artifacts, saved of the main log file to the records repo, and created the gist to boot. And now works in concert with the updates that also catch the case where there are no logs. Looks great!

@aerorahul aerorahul merged commit 989948c into NOAA-EMC:develop Feb 10, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jenkins pipeline does not fail when build_compute.sh all fails
5 participants