-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix error log parsing in compute build CI #3301
Fix error log parsing in compute build CI #3301
Conversation
Running CI on Hercules to test the new feature. |
Build FAILED on Hercules in Build# 1 with error logs:
Follow link here to view the contents of the above file(s): (link) |
Testing on Hercules shows that these changes successfully triggers the creation of a gist with the failed log file. Marking this PR as ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes I saw the error logs showed up and got stored in the Jenkins Artifacts, saved of the main log file to the records repo, and created the gist to boot. And now works in concert with the updates that also catch the case where there are no logs. Looks great!
Description
This PR adds a new feature to capture and report which compute builds failed when running CI.
Resolves #3296
Type of change
Change characteristics
How has this been tested?
Checklist