-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CCPP suite and FASTER option to UFS build #2521
Merged
WalterKolczynski-NOAA
merged 6 commits into
NOAA-EMC:develop
from
guoqing-noaa:prDevelop
Apr 23, 2024
Merged
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
dadecee
update build scripts to include the nest physics and an -f option to …
guoqing-noaa 0be66ff
remove the CCPP_SUITE variable from config.base per suggestion
guoqing-noaa 9c1a384
maintain alphabetical order for the -f option
guoqing-noaa a14547d
move up the -f description
guoqing-noaa ed8bdf6
Update sorc/build_all.sh
guoqing-noaa 3d0c89a
move up the f) option
guoqing-noaa File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,16 +5,17 @@ cwd=$(pwd) | |
|
||
# Default settings | ||
APP="S2SWA" | ||
CCPP_SUITES="FV3_GFS_v17_p8_ugwpv1,FV3_GFS_v17_coupled_p8_ugwpv1" # TODO: does the g-w need to build with all these CCPP_SUITES? | ||
CCPP_SUITES="FV3_GFS_v17_p8_ugwpv1,FV3_GFS_v17_coupled_p8_ugwpv1,FV3_global_nest_v1" # TODO: does the g-w need to build with all these CCPP_SUITES? | ||
PDLIB="ON" | ||
|
||
while getopts ":da:j:vw" option; do | ||
while getopts ":da:fj:vw" option; do | ||
case "${option}" in | ||
d) BUILD_TYPE="Debug";; | ||
a) APP="${OPTARG}";; | ||
j) BUILD_JOBS="${OPTARG}";; | ||
v) export BUILD_VERBOSE="YES";; | ||
w) PDLIB="OFF";; | ||
f) FASTER="ON";; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please place this after the |
||
:) | ||
echo "[${BASH_SOURCE[0]}]: ${option} requires an argument" | ||
;; | ||
|
@@ -31,7 +32,11 @@ source "./tests/module-setup.sh" | |
|
||
MAKE_OPT="-DAPP=${APP} -D32BIT=ON -DCCPP_SUITES=${CCPP_SUITES}" | ||
[[ ${PDLIB:-"OFF"} = "ON" ]] && MAKE_OPT+=" -DPDLIB=ON" | ||
[[ ${BUILD_TYPE:-"Release"} = "Debug" ]] && MAKE_OPT+=" -DDEBUG=ON" | ||
if [[ ${BUILD_TYPE:-"Release"} = "DEBUG" ]] ; then | ||
MAKE_OPT+=" -DDEBUG=ON" | ||
elif [[ "${FASTER:-OFF}" == ON ]] ; then | ||
WalterKolczynski-NOAA marked this conversation as resolved.
Show resolved
Hide resolved
|
||
MAKE_OPT+=" -DFASTER=ON" | ||
fi | ||
COMPILE_NR=0 | ||
CLEAN_BEFORE=YES | ||
CLEAN_AFTER=NO | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be moved up to be in alphabetical order as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. Thanks!