Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PYTHONPATH to soca ocean prep jjob #1292

Merged
merged 2 commits into from
Jan 31, 2023
Merged

Add PYTHONPATH to soca ocean prep jjob #1292

merged 2 commits into from
Jan 31, 2023

Conversation

AndrewEichmann-NOAA
Copy link
Contributor

@AndrewEichmann-NOAA AndrewEichmann-NOAA commented Jan 30, 2023 •
edited by WalterKolczynski-NOAA
Loading

Description

Adds the UFSDA location to PYTHONPATH in soca prep jjob so the path building is not done in script.

Addresses GDASApp issues NOAA-EMC/GDASApp#242 and NOAA-EMC/GDASApp#234

The issues require changes also to GDASApp, but this PR will not break GDASApp as is

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Tested with soca/global-workflow GDASApp ctests on Hera

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • Any dependent changes have been merged and published - TBD

@AndrewEichmann-NOAA
Copy link
Contributor Author

@guillaumevernieres FYI

guillaumevernieres
guillaumevernieres approved these changes Jan 30, 2023
View reviewed changes
Copy link
Contributor

@guillaumevernieres guillaumevernieres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good. We'll have to modify the script in the gdasapp next, but all good for this repo. Thanks @AndrewEichmann-NOAA

@AndrewEichmann-NOAA AndrewEichmann-NOAA mentioned this pull request Jan 30, 2023
Merged
@AndrewEichmann-NOAA AndrewEichmann-NOAA requested review from guillaumevernieres and removed request for aerorahul January 31, 2023 17:15
@WalterKolczynski-NOAA WalterKolczynski-NOAA changed the title add PYTHONPATH to soca prep jjob Add PYTHONPATH to soca prep jjob Jan 31, 2023
@WalterKolczynski-NOAA WalterKolczynski-NOAA changed the title Add PYTHONPATH to soca prep jjob Add PYTHONPATH to soca ocean prep jjob Jan 31, 2023
@WalterKolczynski-NOAA WalterKolczynski-NOAA merged commit 6b5d92d into NOAA-EMC:develop Jan 31, 2023
@AndrewEichmann-NOAA
Copy link
Contributor Author

Thank you!

@AndrewEichmann-NOAA AndrewEichmann-NOAA deleted the feature/use-pythonpath-in-soca branch January 31, 2023 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guillaumevernieres guillaumevernieres guillaumevernieres approved these changes

@WalterKolczynski-NOAA WalterKolczynski-NOAA WalterKolczynski-NOAA approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AndrewEichmann-NOAA @guillaumevernieres @WalterKolczynski-NOAA