Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs in forecast-only mode (GFSv16) #1208

Merged
merged 7 commits into from
Jan 5, 2023
Merged

Fix bugs in forecast-only mode (GFSv16) #1208

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
54eccbf
Update term for forecast-only MODE
KateFriedman-NOAA Dec 13, 2022
208fb90
Add check against forecast-only and cold-start
KateFriedman-NOAA Dec 13, 2022
b831107
Add checks for cycled MODE in archive job
KateFriedman-NOAA Dec 15, 2022
f21a0e5
Add missing COMINsyn paths for tracker job
KateFriedman-NOAA Dec 15, 2022
584580f
Remove errant else that wasn't cleaned out
KateFriedman-NOAA Dec 15, 2022
6b84259
Wrap pgb*anl archiving in cycled check
KateFriedman-NOAA Jan 4, 2023
f372b5e
Address tab/space mixing
KateFriedman-NOAA Jan 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add checks for cycled MODE in archive job 
- Some files are not generated or existing during forecast-only mode and
should not be included in archival.
- Update jobs/rocoto/arch.sh and ush/hpssarch_gen.sh to check for MODE
when defining and running some archives.
  • Loading branch information
@KateFriedman-NOAA
KateFriedman-NOAA committed Dec 15, 2022
commit b831107d70c6df2a64997ba4c634cb17af7e8980
7 changes: 6 additions & 1 deletion jobs/rocoto/arch.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,12 @@ if [ $CDUMP = "gfs" ]; then

#for targrp in gfs_flux gfs_netcdf/nemsio gfs_pgrb2b; do
if [ ${SAVEFCSTNEMSIO:-"YES"} = "YES" ]; then
for targrp in gfs_flux gfs_${format}a gfs_${format}b gfs_pgrb2b; do
targrp_list="gfs_flux gfs_${format}b gfs_pgrb2b"
if [ $MODE = "cycled" ] ; then
targrp_list="${targrp_list} gfs_${format}a"
else
fi
for targrp in $targrp_list; do
htar -P -cvf $ATARDIR/$CDATE/${targrp}.tar `cat $ARCH_LIST/${targrp}.txt`
KateFriedman-NOAA marked this conversation as resolved.
Show resolved Hide resolved
status=$?
if [ $status -ne 0 -a $CDATE -ge $firstday ]; then
Expand Down
83 changes: 54 additions & 29 deletions ush/hpssarch_gen.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,14 +41,16 @@ if [ $type = "gfs" ]; then
rm -f gfsb.txt
rm -f gfs_pgrb2b.txt
rm -f gfs_flux.txt
rm -f gfs_${format}a.txt
if [ $MODE = "cycled" ]; then
rm -f gfs_${format}a.txt
touch gfs_${format}a.txt
fi
rm -f gfs_${format}b.txt
rm -f gfs_restarta.txt
touch gfsa.txt
touch gfsb.txt
touch gfs_pgrb2b.txt
touch gfs_flux.txt
touch gfs_${format}a.txt
touch gfs_${format}b.txt
touch gfs_restarta.txt

Expand All @@ -69,17 +71,21 @@ if [ $type = "gfs" ]; then
echo "${dirname}${head}pgrb2b.0p50.anl.idx " >>gfs_pgrb2b.txt

echo "./logs/${CDATE}/gfs*.log " >>gfsa.txt
echo "${dirname}${head}gsistat " >>gfsa.txt
echo "${dirname}${head}nsstbufr " >>gfsa.txt
echo "${dirname}${head}prepbufr " >>gfsa.txt
echo "${dirname}${head}prepbufr_pre-qc " >>gfsa.txt
echo "${dirname}${head}prepbufr.acft_profiles " >>gfsa.txt
echo "${dirname}${head}pgrb2.0p25.anl " >>gfsa.txt
echo "${dirname}${head}pgrb2.0p25.anl.idx " >>gfsa.txt
echo "${dirname}avno.t${cyc}z.cyclone.trackatcfunix " >>gfsa.txt
echo "${dirname}avnop.t${cyc}z.cyclone.trackatcfunix " >>gfsa.txt
echo "${dirname}trak.gfso.atcfunix.${PDY}${cyc} " >>gfsa.txt
echo "${dirname}trak.gfso.atcfunix.altg.${PDY}${cyc} " >>gfsa.txt
if [ $MODE = "cycled" ]; then
echo "${dirname}${head}gsistat " >>gfsa.txt
echo "${dirname}${head}nsstbufr " >>gfsa.txt
echo "${dirname}${head}prepbufr " >>gfsa.txt
echo "${dirname}${head}prepbufr_pre-qc " >>gfsa.txt
echo "${dirname}${head}prepbufr.acft_profiles " >>gfsa.txt
echo "${dirname}${head}pgrb2.0p25.anl " >>gfsa.txt
echo "${dirname}${head}pgrb2.0p25.anl.idx " >>gfsa.txt
fi
if [ $VRFYTRAK = "YES" ]; then
echo "${dirname}avno.t${cyc}z.cyclone.trackatcfunix " >>gfsa.txt
echo "${dirname}avnop.t${cyc}z.cyclone.trackatcfunix " >>gfsa.txt
echo "${dirname}trak.gfso.atcfunix.${PDY}${cyc} " >>gfsa.txt
echo "${dirname}trak.gfso.atcfunix.altg.${PDY}${cyc} " >>gfsa.txt
fi
echo "${dirname}storms.gfso.atcf_gen.${PDY}${cyc} " >>gfsa.txt
echo "${dirname}storms.gfso.atcf_gen.altg.${PDY}${cyc} " >>gfsa.txt

Expand All @@ -103,11 +109,12 @@ if [ $type = "gfs" ]; then
fi
fi

echo "${dirname}${head}pgrb2.0p50.anl " >>gfsb.txt
echo "${dirname}${head}pgrb2.0p50.anl.idx " >>gfsb.txt
echo "${dirname}${head}pgrb2.1p00.anl " >>gfsb.txt
echo "${dirname}${head}pgrb2.1p00.anl.idx " >>gfsb.txt

if [ $MODE = "cycled" ]; then
echo "${dirname}${head}pgrb2.0p50.anl " >>gfsb.txt
echo "${dirname}${head}pgrb2.0p50.anl.idx " >>gfsb.txt
echo "${dirname}${head}pgrb2.1p00.anl " >>gfsb.txt
echo "${dirname}${head}pgrb2.1p00.anl.idx " >>gfsb.txt
fi

fh=0
while [ $fh -le $FHMAX_GFS ]; do
Expand Down Expand Up @@ -145,11 +152,13 @@ if [ $type = "gfs" ]; then


#..................
echo "${dirname}${head}atmanl${SUFFIX} " >>gfs_${format}a.txt
echo "${dirname}${head}sfcanl${SUFFIX} " >>gfs_${format}a.txt
echo "${dirname}${head}atmi*.nc " >>gfs_${format}a.txt
echo "${dirname}${head}dtfanl.nc " >>gfs_${format}a.txt
echo "${dirname}${head}loginc.txt " >>gfs_${format}a.txt
if [ $MODE = "cycled" ]; then
echo "${dirname}${head}atmanl${SUFFIX} " >>gfs_${format}a.txt
echo "${dirname}${head}sfcanl${SUFFIX} " >>gfs_${format}a.txt
echo "${dirname}${head}atmi*.nc " >>gfs_${format}a.txt
echo "${dirname}${head}dtfanl.nc " >>gfs_${format}a.txt
echo "${dirname}${head}loginc.txt " >>gfs_${format}a.txt
fi

#..................
if [ $OUTPUT_HISTORY = ".true." ]; then
Expand All @@ -163,12 +172,28 @@ if [ $type = "gfs" ]; then
fi

#..................
echo "${dirname}RESTART/*0000.sfcanl_data.tile1.nc " >>gfs_restarta.txt
echo "${dirname}RESTART/*0000.sfcanl_data.tile2.nc " >>gfs_restarta.txt
echo "${dirname}RESTART/*0000.sfcanl_data.tile3.nc " >>gfs_restarta.txt
echo "${dirname}RESTART/*0000.sfcanl_data.tile4.nc " >>gfs_restarta.txt
echo "${dirname}RESTART/*0000.sfcanl_data.tile5.nc " >>gfs_restarta.txt
echo "${dirname}RESTART/*0000.sfcanl_data.tile6.nc " >>gfs_restarta.txt
if [ $MODE = "cycled" ]; then
echo "${dirname}RESTART/*0000.sfcanl_data.tile1.nc " >>gfs_restarta.txt
echo "${dirname}RESTART/*0000.sfcanl_data.tile2.nc " >>gfs_restarta.txt
echo "${dirname}RESTART/*0000.sfcanl_data.tile3.nc " >>gfs_restarta.txt
echo "${dirname}RESTART/*0000.sfcanl_data.tile4.nc " >>gfs_restarta.txt
echo "${dirname}RESTART/*0000.sfcanl_data.tile5.nc " >>gfs_restarta.txt
echo "${dirname}RESTART/*0000.sfcanl_data.tile6.nc " >>gfs_restarta.txt
elif [ $MODE = "forecast-only" ]; then
echo "${dirname}INPUT/gfs_ctrl.nc " >>gfs_restarta.txt
echo "${dirname}INPUT/gfs_data.tile1.nc " >>gfs_restarta.txt
echo "${dirname}INPUT/gfs_data.tile2.nc " >>gfs_restarta.txt
echo "${dirname}INPUT/gfs_data.tile3.nc " >>gfs_restarta.txt
echo "${dirname}INPUT/gfs_data.tile4.nc " >>gfs_restarta.txt
echo "${dirname}INPUT/gfs_data.tile5.nc " >>gfs_restarta.txt
echo "${dirname}INPUT/gfs_data.tile6.nc " >>gfs_restarta.txt
echo "${dirname}INPUT/sfc_data.tile1.nc " >>gfs_restarta.txt
echo "${dirname}INPUT/sfc_data.tile2.nc " >>gfs_restarta.txt
echo "${dirname}INPUT/sfc_data.tile3.nc " >>gfs_restarta.txt
echo "${dirname}INPUT/sfc_data.tile4.nc " >>gfs_restarta.txt
echo "${dirname}INPUT/sfc_data.tile5.nc " >>gfs_restarta.txt
echo "${dirname}INPUT/sfc_data.tile6.nc " >>gfs_restarta.txt
fi

#..................
if [ $DO_WAVE = "YES" ]; then
Expand Down