Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate all machine detection outside of detect_machine.sh #2129

Closed
1 of 3 tasks
WalterKolczynski-NOAA opened this issue Dec 6, 2023 · 3 comments
Closed
1 of 3 tasks
Assignees
Labels
maintenance Regular updates and maintenance work

Comments

@WalterKolczynski-NOAA
Copy link
Contributor

WalterKolczynski-NOAA commented Dec 6, 2023

What new functionality do you need?

ush/detect_machine.sh should be the only place where the machine is identified.

What are the requirements for the new functionality?

Only detect_machine.sh should be looking at paths or hostnames for the purpose of determining what machine the script is being run on. All others scripts with machine-specific code should use the ${MACHINE_ID} variable set by that script to determine branching paths.

This may require expansion of detect_machine.sh to handle compute nodes.

Acceptance Criteria

  • All scripts with machine-dependent code use ${MACHINE_ID} to determine which code to run
  • detect_machine.sh functions on both login and compute nodes of all supported machines
  • Results unchanged

Suggest a solution (optional)

No response

@HenryRWinterbottom
Copy link
Contributor

@WalterKolczynski-NOAA So, can this be closed also?

@aerorahul
Copy link
Contributor

@HenryWinterbottom-NOAA What needs to be done further on this issue?

@HenryRWinterbottom
Copy link
Contributor

I thought this was done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Regular updates and maintenance work
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants